Repository navigation
Conversation
9e83359 to
7e19fd5
Compare
Convert multi-value Strings into a comma-separated String of org.apache.maven.plugin.descriptor.Parameter#defaultValue The underlying Sisu implementaton supports comma separated Strings for collections (https://eclipse.dev/sisu/org.eclipse.sisu.plexus/configuration.html#Collection_Objects). as well as the Maven 4 equivalent at V4MojoConfigurator.class. The old single-value defaultValue is still supported, but for multi-value defaults, use defaultValues instead. This closes #1272
7e19fd5 to
bccf6f7
Compare
gnodet-bot
left a comment
There was a problem hiding this comment.
Verdict: COMMENT — Functionally sound enhancement. The null-based mutual-exclusion logic is correct (ASM only visits explicitly-set annotation attributes, so ParameterAnnotationContent fields default to null for unspecified attributes — the conflict check works correctly even with the annotation interface defaults of "" and {}). Two observations worth addressing:
This review was generated by an AI agent, Hermès on behalf of @gnodet.
gnodet-bot
left a comment
There was a problem hiding this comment.
Reviewed the defaultValues support addition to @Parameter. Three minor documentation and style issues found.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
gnodet-bot
left a comment
There was a problem hiding this comment.
Following up on my earlier reviews — all previously raised issues have been addressed in the latest commits.
- ✅
#Collection_Objects?trailing?in Sisu link — fixed - ✅
"Mojo API"link label for JSR 330 — corrected to"JSR 330" - ✅
/** ... */Javadoc syntax used for inline comment — converted to// - ✅ Comma restriction documented in
defaultValues()Javadoc (noted since first review) - ✅
QueueandDequecoverage inisCollection()— already present in the implementation
LGTM. No remaining issues.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
Convert multi-value Strings into a comma-separated String of org.apache.maven.plugin.descriptor.Parameter#defaultValue
The underlying Sisu implementaton supports comma separated Strings for collections
(https://eclipse.dev/sisu/org.eclipse.sisu.plexus/configuration.html#Collection_Objects). as well as the Maven 4 equivalent at V4MojoConfigurator.class.
This closes #1272
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
check one of the following: