fix(desktop): bound the workbar panel grid row to stop terminal fit/resize loop - #4967
Open
faga295 wants to merge 1 commit into
Open
fix(desktop): bound the workbar panel grid row to stop terminal fit/resize loop#4967faga295 wants to merge 1 commit into
faga295 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4966
Root cause — a layout feedback loop:
.maka-session-workbar-panel[data-overlay][data-placement="right"]isdisplay: gridbut declared no explicit row track, so content fell into an implicitautorow;autorow's size includes its contents' min-content contribution, so the Section inner wrapper (height: 100%) and the terminal panel (height: 100%) grew with xterm's output;ResizeObserver→ xtermfit()→ layout changed → observer fired again: aResizeObserver → fit → resize → growloop on every burst of output.The fix declares an explicit track,
grid-template-rows: minmax(0, 1fr): the1frsizes the track purely from the container's definite height so content no longer participates in track sizing, andmin 0removes the auto row's min-content floor — cutting the loop at its root.Testing
Terminal fits its panel without growing and stops when its Session changes): across 12 consecutiverequestAnimationFrameticks the xterm host stays within the panel bounds. Fails without the CSS change, passes with it.session-workbar.spec.tspasses (6/6); verified the other overlay panels (review / browser / files / inspector / side-chat) haveheight: 100%roots and are unaffected, and the wide-window collapse animation'sdisplay: gridrestore rule still applies.npm run typecheckandcheck:e2e-budgetpass.