Skip to content

ARQ: Fix line and column values on parse errors. - #4434

Open
trueg wants to merge 1 commit into
apache:mainfrom
trueg:parse_error_line_and_column_fix
Open

trueg wants to merge 1 commit into
apache:mainfrom
trueg:parse_error_line_and_column_fix

Conversation

@trueg

@trueg trueg commented Nov 18, 2026 •

Copy link
Copy Markdown

The error message on parse errors already uses the next token's position, while the line and column values are taken from the current token when creating a QueryParseException.

Now if a next token exists, it is used instead. this way the line and column values in the message and the dedicated fields match.

Corresponding Wikidata Platform Fix: https://gitlab.wikimedia.org/repos/wikidata-platform/wdqs/wdqs-jena/-/merge_requests/4


  • Tests are included. (Do we need a test here?)
  • Documentation change and updates are provided for the Apache Jena website (Seems too small a change for a doc update)
  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx) (There is no issue, do I need to create one?)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.


See the Apache Jena "Contributing" guide.

The error message on parse errors already uses the next token's position,
while the line and column values are taken from the current token
when creating a QueryParseException.

Now if a next token exists, it is used instead. this way the line and
column values in the message and the dedicated fields match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant