[Pipe] Batch OPC UA sink writes - #18384
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Target
master.Cherry-pick #18380 from
dev/1.3.The OPC UA sink previously issued and awaited one
writeValueRPC for every measurement in a tablet. This change collects the writes for a tablet and sends them through onewriteValuesrequest.Missing-node recovery is preserved:
Bad_NodeIdUnknownwrites;addNodes;The cherry-pick keeps the compile-time i18n messages and
Tablet#setRowSizeAPI used onmaster.Unit tests cover a successful multi-measurement batch, missing-node creation and selective retry, and a non-recoverable write status.
Verification
Results:
git diff --check origin/master...HEADpassed.Local synthetic benchmark
The local-only benchmark from #18380 compared the previous per-measurement request pattern with the batch request under a simulated 5 ms response delay:
This is a synthetic RPC-count and latency comparison rather than a measurement of production OPC UA server throughput.
This PR has:
Key changed/added classes
IoTDBOpcUaClientIoTDBOpcUaClientTest