Skip to content

HBASE-30320 TestMemStoreLAB#testLABChunkQueue OOM on fast hardware due to unbounded off-pool chunk allocation #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Umeshkumar9414 wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −0
Open

HBASE-30320 TestMemStoreLAB#testLABChunkQueue OOM on fast hardware due to unbounded off-pool chunk allocation #8533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreLAB.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,12 +329,19 @@ public void testForceCopyOfBigCellInto() {

private Thread getChunkQueueTestThread(final MemStoreLABImpl mslab, String threadName,
ExtendedCell cellToCopyInto) {
// Reserve 20% of max heap as safety margin to prevent OOM on fast hardware where threads can
// allocate many GB of chunks within the 1-second test window.
final long maxMemory = ManagementFactory.getMemoryMXBean().getHeapMemoryUsage().getMax();
final long memoryLimit = (long) (maxMemory * 0.8);
Thread thread = new Thread() {
volatile boolean stopped = false;

@Override
public void run() {
while (!stopped) {
if (ManagementFactory.getMemoryMXBean().getHeapMemoryUsage().getUsed() > memoryLimit) {
break;
}
// keep triggering chunk retirement
mslab.copyCellInto(cellToCopyInto);
}
Expand Down