Skip to content

[GLUTEN-13341][VL] Remove the unused veloxToArrow metric - #13344

Open
LuciferYang wants to merge 1 commit into
apache:mainfrom
LuciferYang:gcfix-remove-velox-to-arrow
Open

LuciferYang wants to merge 1 commit into
apache:mainfrom
LuciferYang:gcfix-remove-velox-to-arrow

Conversation

@LuciferYang

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

The native veloxToArrow metric, the time ensureFlattened spends flattening a batch before export, is sent to the JVM in Metrics.SingleMetric, but nothing has read it since #3854. This removes the metric and the code that carries it:

  • the timer in VeloxColumnarBatch::ensureFlattened and BoltColumnarBatch::ensureFlattened, and ColumnarBatch::getExportNanos
  • ResultIterator::setExportNanos and getExportNanos, whose field was never initialized
  • the exportNanos parameter of Runtime::getMetrics and WholeStageResultIterator::getMetrics
  • the veloxToArrow argument of the JNI Metrics constructor, and Metrics.SingleMetric
  • the SingleMetric parameter of MetricsUtil.updateTransformerMetricsInternal and JoinMetricsUpdater.updateJoinMetrics, which only passed it along

The Velox and Bolt backends share cpp/core and the JNI constructor, so both are changed. ClickHouse has its own NativeMetrics class and is not affected.

How was this patch tested?

No new tests. The metrics JSON the JVM reads is unchanged. CI does not build the Bolt C++ code, and those changes were not compiled. The Bolt JVM module compiles.

Was this patch authored or co-authored using generative AI tooling?

Yes. Generated-by: Claude Opus.

Related issue: #13341.

Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the VELOX label Oct 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants