Repository navigation
[GLUTEN-13341][VL] Remove the unused veloxToArrow metric - #13344
Open
LuciferYang wants to merge 1 commit into
Open
LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
The native
veloxToArrowmetric, the timeensureFlattenedspends flattening a batch before export, is sent to the JVM inMetrics.SingleMetric, but nothing has read it since #3854. This removes the metric and the code that carries it:VeloxColumnarBatch::ensureFlattenedandBoltColumnarBatch::ensureFlattened, andColumnarBatch::getExportNanosResultIterator::setExportNanosandgetExportNanos, whose field was never initializedexportNanosparameter ofRuntime::getMetricsandWholeStageResultIterator::getMetricsveloxToArrowargument of the JNIMetricsconstructor, andMetrics.SingleMetricSingleMetricparameter ofMetricsUtil.updateTransformerMetricsInternalandJoinMetricsUpdater.updateJoinMetrics, which only passed it alongThe Velox and Bolt backends share
cpp/coreand the JNI constructor, so both are changed. ClickHouse has its ownNativeMetricsclass and is not affected.How was this patch tested?
No new tests. The metrics JSON the JVM reads is unchanged. CI does not build the Bolt C++ code, and those changes were not compiled. The Bolt JVM module compiles.
Was this patch authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Opus.
Related issue: #13341.