Repository navigation
[GLUTEN-13330][VL] Remap generated build key aliases in the driver-side hash table build - #13332
Open
LuciferYang wants to merge 1 commit into
Open
LuciferYang wants to merge 1 commit into
LuciferYang wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
When
spark.gluten.sql.columnar.backend.velox.driverSideBroadcastHashTableBuildis enabled,buildHashTableWithRuntimeinColumnarBuildSideRelationandUnsafeColumnarBuildSideRelationbuilds the hash table on the driver. It names each join key as it appears in the join, but when a key reaches the build side under a generated alias, the build output names that column differently and the native build fails withField not found: key#329. Available fields are: p_partkey#197, _post_11#329. The failure is caught and the join falls back to building the table on each executor, so results are correct but the driver-side build never takes effect for these joins.#12407 fixed the same problem in the executor-side
buildHashTableby mapping each key to the build output attribute with the same exprId. This applies that mapping inbuildHashTableWithRuntimeas well.How was this patch tested?
Added two cases to
VeloxHashJoinSuitethat run the #12407 query with the driver-side build enabled, once with the on-heap and once with the off-heap build relation, and assert the broadcast relation is aSerializedHashTableBroadcastRelation, that is, the driver-side build did not fall back. Both fail without this change. The #12407 query moves into a shared val used by its original test and the new ones.Was this patch authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Opus.
Related issue: #13330.