Repository navigation
[GLUTEN-13329][VL] Match the TencentOS Server os-release name in the shared library loaders - #13331
Open
LuciferYang wants to merge 3 commits into
Open
LuciferYang wants to merge 3 commits into
LuciferYang wants to merge 3 commits into
Conversation
zhouyuan
approved these changes
Oct 16, 2026
philo-he
approved these changes
Oct 17, 2026
philo-he
left a comment
Member
There was a problem hiding this comment.
LGTM. Please rebase and resolve code conflicts. Thanks.
Velox's CentOS 7 loader was removed in apache#13336; keep the deletion and test only the centos8 loader.
Contributor
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Since #10774, the CentOS shared library loaders match TencentOS with
osName.contains("tencentos"), whereosNameis theNAMEfield of/etc/os-release. TencentOS Server reportsNAME="TencentOS Server", so the check never matches, and withspark.gluten.loadLibFromJar=trueloading fails with "Cannot find SharedLibraryLoader". Before #10774 the check ran on the whole os-release text and matchedID="tencentos".This lowercases the name with
Locale.ROOTbefore the check, in Velox'sSharedLibraryLoaderCentos8and in Bolt'sSharedLibraryLoaderCentos7andSharedLibraryLoaderCentos8. Velox has had no CentOS 7 loader since #13336. The version checks are unchanged: TencentOS 3.2 goes to the centos8 loader, 2.4 goes to Bolt's centos7 loader, and no other registered loader accepts the TencentOS name.How was this patch tested?
Added
SharedLibraryLoaderCentosSuite, which checks Velox's centos8 loader against theNAMEandVERSIONvalues TencentOS Server 3.2 reports, and that 2.4, 3.1 and 4.2 are rejected. The first case fails without this change. The Bolt copies get the same one-line change and compile, but no test or CI job covers backends-bolt.Was this patch authored or co-authored using generative AI tooling?
Yes. Generated-by: Claude Opus.
Related issue: #13329.