Skip to content

[GLUTEN-13329][VL] Match the TencentOS Server os-release name in the shared library loaders - #13331

Open
LuciferYang wants to merge 3 commits into
apache:mainfrom
LuciferYang:gcfix-tencentos-loader
Open

LuciferYang wants to merge 3 commits into
apache:mainfrom
LuciferYang:gcfix-tencentos-loader

Conversation

@LuciferYang

@LuciferYang LuciferYang commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What changes are proposed in this pull request?

Since #10774, the CentOS shared library loaders match TencentOS with osName.contains("tencentos"), where osName is the NAME field of /etc/os-release. TencentOS Server reports NAME="TencentOS Server", so the check never matches, and with spark.gluten.loadLibFromJar=true loading fails with "Cannot find SharedLibraryLoader". Before #10774 the check ran on the whole os-release text and matched ID="tencentos".

This lowercases the name with Locale.ROOT before the check, in Velox's SharedLibraryLoaderCentos8 and in Bolt's SharedLibraryLoaderCentos7 and SharedLibraryLoaderCentos8. Velox has had no CentOS 7 loader since #13336. The version checks are unchanged: TencentOS 3.2 goes to the centos8 loader, 2.4 goes to Bolt's centos7 loader, and no other registered loader accepts the TencentOS name.

How was this patch tested?

Added SharedLibraryLoaderCentosSuite, which checks Velox's centos8 loader against the NAME and VERSION values TencentOS Server 3.2 reports, and that 2.4, 3.1 and 4.2 are rejected. The first case fails without this change. The Bolt copies get the same one-line change and compile, but no test or CI job covers backends-bolt.

Was this patch authored or co-authored using generative AI tooling?

Yes. Generated-by: Claude Opus.

Related issue: #13329.

Copilot AI balanced review requested due to automatic review settings October 15, 2026 17:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the VELOX label Oct 15, 2026

@philo-he philo-he left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase and resolve code conflicts. Thanks.

Velox's CentOS 7 loader was removed in apache#13336; keep the deletion and
test only the centos8 loader.
Copilot AI balanced review requested due to automatic review settings October 17, 2026 18:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@LuciferYang

Copy link
Copy Markdown
Contributor Author

Thanks @philo-he. Merged main in to resolve the conflict. #13336 removed the Velox CentOS 7 loader, so on the Velox side the fix and the test now only cover the centos8 loader (TencentOS 3.2). The Bolt copies of both loaders keep the change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants