build: drop the rust-toolchain.toml pin - #272
Merged
Merged
Conversation
cargo x lint auto-installs taplo-cli via an unpinned cargo install when taplo is not on PATH. Recent taplo-cli releases pull in transitive dependencies (icu_*, time) that require rustc 1.88, so the install fails on a clean environment where the pinned 1.86.0 toolchain is active. The workspace already declares its MSRV with rust-version in Cargo.toml and CI verifies it through the test matrix; every CI job also deleted rust-toolchain.toml before installing its toolchain, so the pin only affected local development. Drop the file and the now-obsolete CI steps, and document the nightly requirement for lint/check in CONTRIBUTING.md.
Member
Author
|
@freakyzoidberg This should resolve the issue you pointed out in the release vote thread. If the experience still has some issue, I'd either try to improve the error message or pin a version for tool. So far, I tend to use latest dev tools to use their nightly features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cargo x lintauto-installs taplo-cli via an unpinnedcargo install taplo-cliwhen taplo is not on PATH (xtask/src/main.rs,ensure_installed). Recent taplo-cli releases pull in transitive dependencies (icu_*,time) that require rustc 1.88, so the install now fails on a clean environment where the pinned 1.86.0 toolchain fromrust-toolchain.tomlis active.Change
Drop
rust-toolchain.tomlentirely:rust-versioninCargo.toml, and CI verifies it through the test matrix, so the pin is redundant for correctness.rust-toolchain.tomlbefore installing its toolchain, meaning the pin only affected local development — where it brokecargo installof lint tools. The now-obsolete deletion steps are removed from CI.CONTRIBUTING.mdsetup instructions are updated: any toolchain at or above the MSRV works for build/test, and a nightly toolchain is required forcargo x lint/cargo x check.Verified locally with
cargo x lintandcargo x check.