Skip to content

build: drop the rust-toolchain.toml pin - #272

Merged
tisonkun merged 1 commit into
apache:mainfrom
tisonkun:build/drop-rust-toolchain-pin
Sep 3, 2026
Merged

build: drop the rust-toolchain.toml pin#272
tisonkun merged 1 commit into
apache:mainfrom
tisonkun:build/drop-rust-toolchain-pin

Conversation

@tisonkun

@tisonkun tisonkun commented Sep 3, 2026

Copy link
Copy Markdown
Member

Problem

cargo x lint auto-installs taplo-cli via an unpinned cargo install taplo-cli when taplo is not on PATH (xtask/src/main.rs, ensure_installed). Recent taplo-cli releases pull in transitive dependencies (icu_*, time) that require rustc 1.88, so the install now fails on a clean environment where the pinned 1.86.0 toolchain from rust-toolchain.toml is active.

Change

Drop rust-toolchain.toml entirely:

  • The workspace already declares its MSRV with rust-version in Cargo.toml, and CI verifies it through the test matrix, so the pin is redundant for correctness.
  • Every CI job already deleted rust-toolchain.toml before installing its toolchain, meaning the pin only affected local development — where it broke cargo install of lint tools. The now-obsolete deletion steps are removed from CI.
  • CONTRIBUTING.md setup instructions are updated: any toolchain at or above the MSRV works for build/test, and a nightly toolchain is required for cargo x lint / cargo x check.

Verified locally with cargo x lint and cargo x check.

cargo x lint auto-installs taplo-cli via an unpinned cargo install when
taplo is not on PATH. Recent taplo-cli releases pull in transitive
dependencies (icu_*, time) that require rustc 1.88, so the install fails
on a clean environment where the pinned 1.86.0 toolchain is active.

The workspace already declares its MSRV with rust-version in Cargo.toml
and CI verifies it through the test matrix; every CI job also deleted
rust-toolchain.toml before installing its toolchain, so the pin only
affected local development. Drop the file and the now-obsolete CI
steps, and document the nightly requirement for lint/check in
CONTRIBUTING.md.
@tisonkun
tisonkun merged commit caa60a1 into apache:main Sep 3, 2026
10 checks passed
@tisonkun
tisonkun deleted the build/drop-rust-toolchain-pin branch September 3, 2026 08:02
@tisonkun

tisonkun commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

@freakyzoidberg This should resolve the issue you pointed out in the release vote thread.

If the experience still has some issue, I'd either try to improve the error message or pin a version for tool. So far, I tend to use latest dev tools to use their nightly features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant