Allow removing VMs from instance groups

[nvazquez]

Description

This PR fixes a limitation on the instance groups functionality. Once a VM was added to an instance group, it was not possible to remove it from the group (the workaround was updating the instance_group_vm_map table or removing the VM)

This fix allows passing an empty group parameter on the updateVirtualMachine API to remove the VM from its current instance group

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested updating VM group via UI to existing instance groups and to the empty field to remove the VM from its current group.

How did you try to break this feature and the system with this change?

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19538

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.02%. Comparing base (dfff32e) to head (d8c8dea).
⚠️ Report is 1 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	33.33%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #14395   +/-   ##
=========================================
  Coverage     18.01%   18.02%           
- Complexity    16265    16274    +9     
=========================================
  Files          5936     5936           
  Lines        536395   536401    +6     
  Branches      65701    65704    +3     
=========================================
+ Hits          96658    96708   +50     
+ Misses       428710   428664   -46     
- Partials      11027    11029    +2     

Flag	Coverage Δ
uitests	4.04% <ø> (-0.01%)	⬇️
unittests	19.10% <33.33%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nvazquez]

Thanks @Damans227 - review comments addressed

@blueorangutan package

[blueorangutan]

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19541

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[weizhouapache]

code lgtm

[Damans227]

Thanks @Damans227 - review comments addressed

@nvazquez that covers both, thanks

[Damans227]

thanks @nvazquez, fix looks right. LGTM

[blueorangutan]

[SF] Trillian test result (tid-17133)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54549 seconds
Marvin logs: [archive removed]
Smoke tests completed. 144 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestCreateVolume>:setup	Error	0.00	test_volumes.py
test_01_root_volume_encryption	Error	1.34	test_volumes.py
test_02_data_volume_encryption	Error	1.25	test_volumes.py
test_03_root_and_data_volume_encryption	Error	1.28	test_volumes.py
ContextSuite context=TestVolumes>:setup	Error	20.68	test_volumes.py
ContextSuite context=TestVPCRedundancy>:setup	Error	0.00	test_vpc_redundant.py
test_01_VPC_nics_after_destroy	Failure	163.39	test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobs	Error	1.48	test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure	Error	1.60	test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected	Failure	18.60	test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected	Failure	21.57	test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected	Failure	32.34	test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardown	Error	33.49	test_host_maintenance.py

[shwstppr]

code lgtm, didn't test

[nvazquez]

@blueorangutan test

[blueorangutan]

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-17149)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 52099 seconds
Marvin logs: [archive removed]
Smoke tests completed. 149 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File