Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14385 +/- ##
============================================
- Coverage 18.02% 18.01% -0.01%
+ Complexity 16248 16244 -4
============================================
Files 5936 5936
Lines 535866 535866
Branches 65614 65614
============================================
- Hits 96574 96524 -50
- Misses 428291 428352 +61
+ Partials 11001 10990 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two setup scripts that set the secret keys for db.properties fall back to the word "password" when no key is given, and their help shows that as a normal choice. So many setups end up with keys anyone can guess. This prints a note when an easy to guess key is used, and the help now says to pass a random key on a new setup and keep the old key on an existing one. Nothing else changes.
Original change by @mprokopchuk.
Test:
Ran both scripts with the default keys, then with random keys.
Before: no note with the default keys.
After: a note with the default keys, none with random keys.