Introduction of Netapp Ontap iSCSI pool type by piyush5netapp · Pull Request #14192 · apache/cloudstack

piyush5netapp · 2026-09-17T10:30:18Z

Description

This PR does covers below mentioned things

Introduces the new pool type "OntapiSCSI" for Netapp ONTAP provider for iSCSI usecase.
Introduction of new OntapIscsiStorageAdaptor for new pool type OntapiSCSI.
Removed all the changes we did in common IscsiAdmStorageAdaptor for separation of concern and less blast radius.
Enables vm snapshot UI icon for VM which is in Stopped state and disk is residing on OntapiSCSI pool.
Ontap driver start claiming cross cluster and within cluster migration path.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

All the VM, volume workflows has been tested for Netapp ONTAP provider. Compute only migration of a Live VM has been tested.

How did you try to break this feature and the system with this change?

piyush5netapp · 2026-09-21T04:18:41Z

@winterhazel @weizhouapache I have raised this PR for the introduction of new iscsi pool type for Netapp ONTAP. I remember you guys were also of the same opinion for a new pool type for Netapp ONTAP as part of some previous PR.. Please have a look at this PR and share your feedback.

Copilot

Copilot review overview

🟡 Changes recommended

Existing pools can break after upgrade, unsupported format validation can orphan LUNs, and template creation still rejects RAW ONTAP iSCSI volumes.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 2 · 1

Open (3)

Validate volume format before creating the ONTAP LUN · New
Migrate legacy ONTAP iSCSI pool types · New
Allow ONTAP iSCSI when creating templates from managed volumes · New

What changed in this PR

Adds OntapiSCSI as a first-class ONTAP iSCSI storage-pool type across management, KVM agent, and data-motion paths.

Changes:

Adds the new pool enum and lifecycle mapping.
Adds KVM adaptor and RAW image-format handling.
Extends validation and tests for ONTAP iSCSI behavior.

File	Description
`api/src/main/java/com/cloud/storage/Storage.java`	Defines `OntapiSCSI`.
`server/src/main/java/com/cloud/api/ApiDBUtils.java`	Recognizes RAW ONTAP images.
`plugins/storage/volume/ontap/src/main/java/.../OntapPrimaryDatastoreLifecycle.java`	Maps iSCSI pools to the new type.
`plugins/storage/volume/ontap/src/main/java/.../OntapPrimaryDatastoreDriver.java`	Validates protocols and assigns formats.
`plugins/hypervisors/kvm/src/main/java/.../OntapIscsiStorageAdaptor.java`	Registers the KVM adaptor.
`plugins/hypervisors/kvm/src/main/java/.../KVMStorageProcessor.java`	Handles RAW ONTAP pools.
`engine/storage/datamotion/src/main/java/.../StorageSystemDataMotionStrategy.java`	Allows RAW ONTAP migration formats.
`api/src/test/java/com/cloud/storage/StorageTest.java`	Tests pool capabilities.
`plugins/storage/volume/ontap/src/test/java/.../OntapPrimaryDatastoreLifecycleTest.java`	Tests pool initialization.
`plugins/storage/volume/ontap/src/test/java/.../OntapPrimaryDatastoreDriverTest.java`	Tests format and validation behavior.
`plugins/hypervisors/kvm/src/test/java/.../OntapIscsiStorageAdaptorTest.java`	Tests adaptor discovery and RAW behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.


                    volumeVO.setPoolType(storagePool.getPoolType());
                    volumeVO.setPoolId(storagePool.getId());
+                    volumeVO.setFormat(getImageFormat(storagePool));


piyush5netapp · 2026-09-23T06:50:31Z

                break;
            case ISCSI:
-                parameters.setType(Storage.StoragePoolType.Iscsi);
+                parameters.setType(Storage.StoragePoolType.OntapiSCSI);


@weizhouapache I have already considered this migration path and I am ready with the sql command. I currently dont see the upgrade code from 4.23.0.0 to 4.24.0.0 . I have that code almost ready with me. One thing I want to confirm is about the format of new release version i.e 4.24.0.0 or 24.0.0. since filename will be named accordingly.

should the upgrade also fix the volumes on these pools? they keep the old pool type and still say qcow2, while new ones are raw

yes, volumes on these pools as well pool both the field will be updated with the new value . I will tag you there once I raise the PR for the reviews.

the 24.0.0 upgrade file is on main now (schema-42300to2400.sql). can we add the pool and volume update here? if this merges first, existing pools cant create volumes after an upgrade

                !(imageFormat == ImageFormat.RAW && (StoragePoolType.PowerFlex == poolType ||
-                StoragePoolType.FiberChannel == poolType))) {
-            throw new CloudRuntimeException(String.format("Only the following image types are currently supported: %s, %s, %s, %s (for PowerFlex and FiberChannel)",
+                StoragePoolType.FiberChannel == poolType || StoragePoolType.OntapiSCSI == poolType))) {


codecov · 2026-09-21T06:22:29Z

Codecov Report

❌ Patch coverage is 66.66667% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.92%. Comparing base (27722a5) to head (58d70a2).
⚠️ Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
...ck/storage/driver/OntapPrimaryDatastoreDriver.java	70.83%	2 Missing and 5 partials ⚠️
...torage/motion/StorageSystemDataMotionStrategy.java	0.00%	2 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java	0.00%	2 Missing ⚠️
server/src/main/java/com/cloud/api/ApiDBUtils.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #14192      +/-   ##
============================================
+ Coverage     19.91%   19.92%   +0.01%     
- Complexity    20175    20192      +17     
============================================
  Files          6372     6373       +1     
  Lines        577139   577168      +29     
  Branches      70682    70689       +7     
============================================
+ Hits         114913   114982      +69     
+ Misses       449664   449618      -46     
- Partials      12562    12568       +6

Flag	Coverage Δ
uitests	`3.71% <ø> (ø)`
unittests	`21.19% <66.66%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

piyush5netapp · 2026-09-28T06:00:05Z

Moving this back to draft PR as some more modification has been done on this. Will update and open for review again in few days.

#115) ### Description enabling VM snapshot for ISCSI stopped vm's in UI using ontapiSCSI pool type This PR...           ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [X] Bug fix (non-breaking change which fixes an issue) - [ ] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) - [ ] Build/CI - [ ] Test (unit or integration test code) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [ ] Minor #### Bug Severity - [ ] BLOCKER - [ ] Critical - [ ] Major - [X] Minor - [ ] Trivial ### Screenshots (if appropriate): ### How Has This Been Tested? 1) created a ISCSI vm and stopped IT 2) Took a snapshot in stopped state 3) powered On the VM then created a file on it and write in to it. 4) Powered of the vm and reverted to snapshot that was taken when it was in stopped state 5) after revert verified that file and contents are gone before reverting: <img width="724" height="159" alt="Screenshot 2026-10-08 at 12 03 39 PM" src="https://github.com/user-attachments/assets/3f5861d2-fde9-4775-9f07-2a778d16dd03" /> after reverting: <img width="825" height="475" alt="Screenshot 2026-10-08 at 12 02 09 PM" src="https://github.com/user-attachments/assets/b515bc19-e582-4850-90c6-e7628cfc9486" />   #### How did you try to break this feature and the system with this change?

…r serial number and by-id instead of by-path

…ap as new adapter for ontap exist now

piyush5netapp · 2026-10-15T15:41:48Z

Moving this back to draft PR as some more modification has been done on this. Will update and open for review again in few days.

@winterhazel @weizhouapache @nvazquez This PR is ready for review now.

new pool type conflicts resolution

5661946

boring-cyborg Bot added component:api component:kvm component:primary-storage component:storage labels Sep 17, 2026

UT failure fix

58d70a2

piyush5netapp marked this pull request as ready for review September 17, 2026 11:09

winterhazel added this to the 24.0 milestone Sep 19, 2026

weizhouapache requested a lite review from Copilot September 21, 2026 06:13

Copilot started reviewing on behalf of weizhouapache September 21, 2026 06:14

View session

Copilot AI reviewed Sep 21, 2026

View reviewed changes

winterhazel self-requested a review October 8, 2026 03:14

sathvikaragi and others added 2 commits October 14, 2026 22:05

ontap-new-iscsi-pool-type: added migration as well as adapter code fo…

ee919af

…r serial number and by-id instead of by-path

boring-cyborg Bot added the component:UI label Oct 15, 2026

removing the changes in iscsiadmadapter which were introduced for ont…

dbff797

…ap as new adapter for ontap exist now

boring-cyborg Bot added the component:iscsi label Oct 15, 2026

Navigation Menu

Repository navigation

Introduction of Netapp Ontap iSCSI pool type - #14192

Introduction of Netapp Ontap iSCSI pool type #14192
piyush5netapp wants to merge 5 commits into
apache:mainfrom
NetApp:ontap-new-iscsi-pool-type

piyush5netapp commented Sep 17, 2026 •

edited

Loading

Uh oh!

piyush5netapp commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

piyush5netapp Sep 23, 2026

Uh oh!

Damans227 Oct 14, 2026

Uh oh!

piyush5netapp Oct 14, 2026

Uh oh!

Damans227 Oct 15, 2026

Uh oh!

codecov Bot commented Sep 21, 2026 •

edited

Loading

Uh oh!

piyush5netapp commented Sep 28, 2026

Uh oh!

piyush5netapp commented Oct 15, 2026 •

edited

Loading

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

piyush5netapp commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

piyush5netapp commented Sep 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

piyush5netapp Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

piyush5netapp Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

Damans227 Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

piyush5netapp commented Sep 28, 2026

Uh oh!

piyush5netapp commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

piyush5netapp commented Sep 17, 2026 •

edited

Loading

codecov Bot commented Sep 21, 2026 •

edited

Loading

piyush5netapp commented Oct 15, 2026 •

edited

Loading