Skip to content

Fix panic when serializing UUID-typed request parameters #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abh1sar merged 1 commit into from
Aug 5, 2026
Merged

Fix panic when serializing UUID-typed request parameters #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudstack/AsyncjobService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ func (p *ListAsyncJobsParams) toURLValues() url.Values {
u.Set("listall", vv)
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
}
if v, found := p.p["page"]; found {
vv := strconv.Itoa(v.(int))
Expand Down
4 changes: 2 additions & 2 deletions cloudstack/HostService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2842,7 +2842,7 @@ func (p *ListHostsParams) toURLValues() url.Values {
u.Set("keyword", v.(string))
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
}
if v, found := p.p["name"]; found {
u.Set("name", v.(string))
Expand Down Expand Up @@ -3546,7 +3546,7 @@ func (p *ListHostsMetricsParams) toURLValues() url.Values {
u.Set("keyword", v.(string))
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
}
if v, found := p.p["name"]; found {
u.Set("name", v.(string))
Expand Down
8 changes: 4 additions & 4 deletions cloudstack/ManagementService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ func (p *CancelShutdownParams) toURLValues() url.Values {
return u
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
}
return u
}
Expand Down Expand Up @@ -765,7 +765,7 @@ func (p *PrepareForShutdownParams) toURLValues() url.Values {
return u
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
}
return u
}
Expand Down Expand Up @@ -838,7 +838,7 @@ func (p *ReadyForShutdownParams) toURLValues() url.Values {
return u
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
Comment thread
abh1sar marked this conversation as resolved.
}
return u
}
Expand Down Expand Up @@ -914,7 +914,7 @@ func (p *TriggerShutdownParams) toURLValues() url.Values {
return u
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
}
return u
}
Expand Down
4 changes: 2 additions & 2 deletions cloudstack/WebhookService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ func (p *DeleteWebhookDeliveryParams) toURLValues() url.Values {
u.Set("id", v.(string))
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
}
if v, found := p.p["startdate"]; found {
u.Set("startdate", v.(string))
Expand Down Expand Up @@ -878,7 +878,7 @@ func (p *ListWebhookDeliveriesParams) toURLValues() url.Values {
u.Set("keyword", v.(string))
}
if v, found := p.p["managementserverid"]; found {
u.Set("managementserverid", v.(string))
u.Set("managementserverid", string(v.(UUID)))
}
if v, found := p.p["page"]; found {
vv := strconv.Itoa(v.(int))
Expand Down
4 changes: 3 additions & 1 deletion generate/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,8 +1355,10 @@ func (s *service) generateConvertCode(cmd, name, typ string) {
pn := s.pn

switch typ {
case "string", "UUID":
case "string":
pn("u.Set(\"%s\", v.(string))", name)
case "UUID":
pn("u.Set(\"%s\", string(v.(UUID)))", name)
Comment thread
abh1sar marked this conversation as resolved.
case "int":
pn("vv := strconv.Itoa(v.(int))")
pn("u.Set(\"%s\", vv)", name)
Expand Down
Loading