Skip to content

Adds support to upload k8s ISO from local - #147

Draft
Pearl1594 wants to merge 2 commits into
support-4.22.1.0from
4.22.1-uploadK8sISO
Draft

Adds support to upload k8s ISO from local#147
Pearl1594 wants to merge 2 commits into
support-4.22.1.0from
4.22.1-uploadK8sISO

Conversation

@Pearl1594

Copy link
Copy Markdown
Contributor

Adds support to upload k8s binaries / data ISO from local introduced with apache/cloudstack#9561 in 4.22.0 - enabling API in 4.22.1.0 SDK

@abh1sar abh1sar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to #144 ,
"getUploadParamsForKubernetesSupportedVersion": "uploadParams"
should be added to
in generate.go -> nestedResponse

return &r, nil
}

type GetUploadParamsForKubernetesSupportedVersionResponse struct {

@abh1sar abh1sar Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bug in CloudStack.
The api says that it returns KubernetesSupportedVersionResponse.class

@APICommand(name = "getUploadParamsForKubernetesSupportedVersion",
        description = "Upload a supported Kubernetes version",
        responseObject = KubernetesSupportedVersionResponse.class,
        responseView = ResponseObject.ResponseView.Full,
        entityType = {KubernetesSupportedVersion.class},
        authorized = {RoleType.Admin})

But it actually returns GetUploadParamsResponse

GetUploadParamsResponse response = kubernetesVersionService.registerKubernetesSupportedVersionForPostUpload(this);
            if (response == null) {
                throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to add Kubernetes supported version");
            }
            response.setResponseName(getCommandName());
            setResponseObject(response);

how do you think we should handle it? @Pearl1594

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we let this remain open until we fix it upstream. Let's open an issue in the CloudStack repo and link it here to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants