Adds support to upload k8s ISO from local - #147
Draft
Pearl1594 wants to merge 2 commits into
Draft
Conversation
abh1sar
reviewed
Aug 4, 2026
| return &r, nil | ||
| } | ||
|
|
||
| type GetUploadParamsForKubernetesSupportedVersionResponse struct { |
There was a problem hiding this comment.
This looks like a bug in CloudStack.
The api says that it returns KubernetesSupportedVersionResponse.class
@APICommand(name = "getUploadParamsForKubernetesSupportedVersion",
description = "Upload a supported Kubernetes version",
responseObject = KubernetesSupportedVersionResponse.class,
responseView = ResponseObject.ResponseView.Full,
entityType = {KubernetesSupportedVersion.class},
authorized = {RoleType.Admin})
But it actually returns GetUploadParamsResponse
GetUploadParamsResponse response = kubernetesVersionService.registerKubernetesSupportedVersionForPostUpload(this);
if (response == null) {
throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to add Kubernetes supported version");
}
response.setResponseName(getCommandName());
setResponseObject(response);
how do you think we should handle it? @Pearl1594
Contributor
Author
There was a problem hiding this comment.
Then we let this remain open until we fix it upstream. Let's open an issue in the CloudStack repo and link it here to track it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to upload k8s binaries / data ISO from local introduced with apache/cloudstack#9561 in 4.22.0 - enabling API in 4.22.1.0 SDK