[WIP] fix: read Dict(FixedSizeBinary) from parquet without dict encoding

[Jefffrey]

Which issue does this PR close?

• Closes InvalidArgumentError("Expected 1 buffers in array of type FixedSizeBinary(4), got 2" #9247

Rationale for this change

If a column Dictionary(FixedSizeBinary) was written to a parquet file, but with dictionary encoding turned off (so encoded only as PLAIN), then reading that file back into a Dictionary(FixedSizeBinary) lead to an unavoidable panic so roundtrip was not possible. Fixing this bug.

What changes are included in this PR?

Coerce the binary values to fixedsizebinary when reading from non-dictionary encoded values to ensure array construction is respected.

Are these changes tested?

Yes, added new tests.

Are there any user-facing changes?

No.

[Jefffrey]

From the reproduction, added one_column_roundtrip() usage here to test roundtrip where one of the cases is disabling dictionary encoding entirely

Rest of test changes is just restructuring

[Jefffrey]

Matching what was done above in the Self::Dict path:

arrow-rs/parquet/src/arrow/buffer/dictionary_buffer.rs

Lines 159 to 168 in 7616e10

	let values = if let ArrowType::FixedSizeBinary(size) = **value_type {
	let binary = values.as_binary::<i32>();
	Arc::new(FixedSizeBinaryArray::new(
	size,
	binary.values().clone(),
	binary.nulls().cloned(),
	)) as _
	} else {
	values
	};

• as introduced originally by feat: Support round trip reading/writing Arrow type Dictionary(_, FixedSizeBinary(_)) to Parquet #7446

This is because values.into_array() assumed a generic byte offset array:

arrow-rs/parquet/src/arrow/buffer/offset_buffer.rs

Lines 132 to 146 in 7616e10

	/// Converts this into an [`ArrayRef`] with the provided `data_type` and `null_buffer`
	pub fn into_array(self, null_buffer: Option<Buffer>, data_type: ArrowType) -> ArrayRef {
	let array_data_builder = ArrayDataBuilder::new(data_type)
	.len(self.len())
	.add_buffer(Buffer::from_vec(self.offsets))
	.add_buffer(Buffer::from_vec(self.values))
	.null_bit_buffer(null_buffer);
	let data = match cfg!(debug_assertions) {
	true => array_data_builder.build().unwrap(),
	false => unsafe { array_data_builder.build_unchecked() },
	};
	make_array(data)
	}

Which is the wrong structure for a fixedsizebinary array (we don't have offsets buffer, etc.)

[Jefffrey]

references for myself

• feat: Support round trip reading/writing Arrow type Dictionary(_, FixedSizeBinary(_)) to Parquet #7446
• [parquet] Avoid materializing native primitive array when column's arrow type is Dictionary #8250

[github-actions]

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.