perf(arrow/array): reuse TableReader scratch slices - #1200
Draft
fallintoplace wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
TableReader.Nextallocated two column slices for every record batch.This keeps the batch slice on
TableReaderand reads the current chunks again after finding the batch size.NewRecordBatchcopies the input slice, so the scratch slice can be safely reused on the next call.Benchmark
The benchmark reuses one reader across passes. It uses Int32 columns with 256 rows per chunk.
256 columns x 256 chunks:
The benchmark covers 4, 32, and 256 columns with 32 and 256 chunks.
Tests
go test ./arrow/array -count=1go test -race ./arrow/array -run TestTableReader -count=1