perf(arrow/compute): take chunked binary values without concatenation - #1199
Draft
fallintoplace wants to merge 1 commit into
Draft
perf(arrow/compute): take chunked binary values without concatenation#1199fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Chunked string and binary
takecurrently concatenates all value chunks before selecting rows.This adds a chunk-aware path for:
The new path resolves global indices to source chunks and copies only selected values. It keeps one output chunk per index chunk and preserves null and bounds behavior.
Benchmark
64 chunks x 4096 rows, 32-byte values, random indices, Apple M1 Pro:
The benchmark covers 8 and 64 chunks, 1% / 10% / 50% / 100% selection, and all four types.
Tests
go test ./arrow/compute/... -count=1