perf(parquet): batch plain BYTE_ARRAY encoding - #1193
Draft
fallintoplace wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
PlainByteArrayEncoder.Putcurrently callsPutByteArrayfor every value. Each call checks sink capacity, writes the 4-byte length, then writes the payload. Large batches repeat that sink work for every value.What changes are included in this PR?
Putand all-validPutSpacedwith 1,048,576 values at three widths.The single-value
PutByteArraypath is unchanged.PutSpacedbenefits through its existing valid-run batching.Medians from 6 runs on an Apple M1 Pro were:
Allocation counts are unchanged.
Are these changes tested?
go test ./parquet/... -count=1go test ./parquet/internal/encoding -run "^$" -bench "^BenchmarkEncodePlainByteArray$" -benchmem -count=6The existing encoding suite covers plain BYTE_ARRAY round trips and spaced validity patterns.
Are there any user-facing changes?
No. The encoded Parquet bytes and public API are unchanged.