perf(parquet): reuse DataPageV2 assembly buffer for eager writes - #1192
Draft
fallintoplace wants to merge 1 commit into
Draft
perf(parquet): reuse DataPageV2 assembly buffer for eager writes#1192fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
buildDataPageV2creates a newbytes.Bufferfor every page when joining levels with encoded values. Pages without active dictionary encoding are written synchronously, so their assembly storage does not need to survive the call. Reallocating it for every page adds page-sized allocation churn.What changes are included in this PR?
Medians from 6 runs on an Apple M1 Pro were:
Are these changes tested?
go test ./parquet/... -count=1go test ./parquet/file -run "^$" -bench "^BenchmarkWriteDataPageV2Eager$" -benchmem -count=6The Parquet suite includes multi-page DataPageV2 dictionary coverage for the retained-page path.
Are there any user-facing changes?
No. The Parquet output and public API are unchanged.