perf(arrow/array): bulk append list nulls and empty values - #1187
Draft
fallintoplace wants to merge 1 commit into
Draft
perf(arrow/array): bulk append list nulls and empty values#1187fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
marked this pull request as draft
August 12, 2026 13:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
These bulk APIs currently call the scalar append path once per list slot. Empty and null variable-sized lists do not append child values, so only the parent validity and dimensions need updating.
This follows the batching shape used by the C++ list builders:
https://github.com/apache/arrow/blob/485499fd02ea2b0c323d67871fbe96aae4232504/cpp/src/arrow/array/builder_nested.h#L138-L160
For ListView, this keeps Go's current physical representation by repeating the current child offset with a zero size.
Benchmark
Apple M1 Pro, Go 1.26.3. Representative medians from three to five runs with 65,536 slots:
Regular-list allocations drop from 45 to 18 per batch. List-view allocations drop from 68 to 25. The
n=1cases stay within benchmark noise.Tests
go test ./arrow/array -count=1go test -race ./arrow/array -run 'TestListBuilderBulkAppendNullsAndEmptyValues|TestList|TestLargeList' -count=1go vet ./arrow/arraygo test -p 1 ./...