perf(parquet): encode spaced booleans without compaction - #1175
Open
fallintoplace wants to merge 2 commits into
Open
perf(parquet): encode spaced booleans without compaction#1175fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
fallintoplace
marked this pull request as ready for review
August 12, 2026 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Plain Boolean spaced encoding currently counts valid bits, allocates a compacted bitmap, copies valid runs into it, and then copies that bitmap into the encoder buffer.
Short unaligned runs also create bitmap readers and writers for every copy. This is expensive for common nullable patterns.
What changes are included in this PR?
Apple M1 Pro results for 65,536 values with
-cpu=1:For the short-run patterns:
Are these changes tested?
Yes.
go test ./parquet/...go test -race ./parquet/internal/encodinggo vet -composites=false ./parquet/internal/encodingAre there any user-facing changes?
No.