Skip to content

fix(prometheus): bump nginx-lua-prometheus-api7 to 1.1.1 - #14150

Merged
AlinsRan merged 1 commit into
apache:masterfrom
AlinsRan:chore/bump-prometheus-1.1.1
Nov 5, 2026
Merged

AlinsRan merged 1 commit into
apache:masterfrom
AlinsRan:chore/bump-prometheus-1.1.1

Conversation

@AlinsRan

@AlinsRan AlinsRan commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Description

Bump nginx-lua-prometheus-api7 from 1.1.0-1 to 1.1.1-1.

1.1.1 updates a metric's pending increment in place instead of allocating a new {v, t} table on every incr() before the next sync() (api7/nginx-lua-prometheus#28). A histogram observation calls incr() for the count, the sum and every bucket it falls into, so the HTTP latency histograms allocate several dozen short-lived tables per request today. The change has no API or configuration impact; 1.1.0 and 1.1.1 differ only in prometheus_resty_counter.lua.

nginx-lua-prometheus-api7-1.1.1-1 is published on LuaRocks.

t/plugin/prometheus.t to prometheus4.t were run locally against 1.1.1 and 1.1.0. Both fail only on assertions that also fail on master locally ([error] checks hit by lua-resty-events failed to receive the header bytes noise, and prometheus.t TEST 41).

Which issue(s) this PR fixes:

None.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@membphis membphis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlinsRan
AlinsRan merged commit 5222007 into apache:master Nov 5, 2026
20 checks passed
@AlinsRan
AlinsRan deleted the chore/bump-prometheus-1.1.1 branch November 5, 2026 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants