refactor(wolf-rbac): separate route and consumer settings - #13929
Open
shreemaan-abhishek wants to merge 3 commits into
Open
refactor(wolf-rbac): separate route and consumer settings#13929shreemaan-abhishek wants to merge 3 commits into
shreemaan-abhishek wants to merge 3 commits into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wolf-rbaccurrently mixes Wolf connection/output settings with Consumer identity. This makes Route behavior depend on Consumer configuration that is unavailable before a Consumer is matched.This PR:
appidin Consumer configurationserver,header_prefix, andssl_verifyto Route/Service configurationThis is a breaking schema change.
Migration
Before upgrading, move
server,header_prefix, andssl_verifyfrom each Consumer to every Route/Service usingwolf-rbac; leave onlyappidon the Consumer. If Consumers used different values on one Route, split or standardize those settings. Routes exposing Wolf APIs must configure bothpublic-apiandwolf-rbac.Checklist