Repository navigation
fix: recognize quoted Codex MCP table headers - #122
Closed
dayebishouji wants to merge 1 commit into
Closed
dayebishouji wants to merge 1 commit into
dayebishouji wants to merge 1 commit into
Conversation
alkor2000
pushed a commit
that referenced
this pull request
Oct 14, 2026
A valid Codex config declaring [mcp_servers."aoci"] or [mcp_servers.'aoci'] was reported as not installed, and the installer then appended a bare [mcp_servers.aoci], leaving a duplicate TOML table. The shared installer and status predicate now matches the complete table header in its bare, basic-quoted, and literal-quoted spellings, with optional whitespace and a trailing comment, so an existing config is left byte-for-byte unchanged. A commented header still does not count as installed. Landed from PR #122 by dayebishouji with its governance files dropped; the maintainer regenerates the Baseline and cognition Entries in the closing commit of this batch. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Landed on main as 0ff0414 under your authorship, with the two governance files dropped and regenerated in the closing commit of this batch, the same way #119 went in. Nothing in the code part changed. Ships in rc21. One note for next time: you can leave Release: https://github.com/aoci-spec/aoci-code/releases/tag/v0.1.0-rc21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes and why
A valid Codex config using
[mcp_servers."aoci"]was reported as uninstalled. Running the installer then appended[mcp_servers.aoci], creating a duplicate TOML table. Recognize the direct bare, basic-quoted, and literal-quoted spellings of this table header in the shared installer/status predicate, including optional whitespace and trailing comments. An existing config is now left byte-for-byte unchanged.Affected public contracts
--jsonshapesspec/public/or machine vocabularyCompatibility: existing unquoted configs behave as before. The generated Baseline fingerprints and Code Volume entry are updated for this change.
Verification
make fastpassedmake full(covered throughmake verify; see environment notes)python3 scripts/blackbox/mcp_conformance.pypassed (53/53)python3 scripts/blackbox/mcp_scenarios.pypassed (75/75)python3 scripts/blackbox/mcp_lifecycle.pypassed in split runs: Linux non-database cases (71 pass) and Windows Docker database cases (19 pass)internal/hookstests, AOCI Verify/Check/Guide, staticcheck, vulnerability scan, race tests, clean-room smoke, and axis-self (80/80) passed.make verifywas run in WSL. Its aggregate exit was nonzero becausestaticcheckandgovulncheckcould not findgoon the WSL PATH, and the lifecycle database case could not reach Docker there. After adding Go to PATH, both checks passed; the database case passed separately against Windows Docker.Operating system impact
The same TOML detection runs on Linux, macOS, and Windows. The regression test uses platform-independent config text.
Migration and recovery
No persisted format change or migration is needed.
Cognition