Repository navigation
Escape text values in OutputXML - #26
Merged
Merged
Conversation
OutputXML wrote JSON string values into the XML verbatim, so a value containing <, > or & (e.g. "AT&T" or "<i>") produced malformed XML that no XML parser could read back. Escape those characters in text nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OutputXMLwrites JSON string values into the XML as-is. Any value that contains<,>or&therefore produces output that isn't well-formed XML:encoding/xml rejects the old output (
XML syntax error ... expected attribute name in element).Change: text nodes now go through a small
strings.Replacerthat escapes&,<and>. Element names andInnerText()are not touched.Test:
TestOutputXMLEscapesTextcompares the exact output and checks thatxml.Unmarshaldecodes it back to the original strings. The test fails without the change and passes with it.go test ./...passes.