test: add Headers coverage and benchmark - #25
Draft
anonrig wants to merge 1 commit into
Draft
Conversation
Add WHATWG Headers unit tests and a fetch/headers benchmark so Node can track the API after the implementation change lands in undici. Refs: nodejs/undici#5699 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
cursor
Bot
force-pushed
the
cursor/headers-class-performance-859a
branch
from
August 18, 2026 01:59
3ea8120 to
eb22154
Compare
cursor
Bot
force-pushed
the
cursor/headers-class-performance-859a
branch
from
August 18, 2026 02:06
eb22154 to
2edacb0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2edacb0. Configure here.
|
|
||
| // Keep a live use so V8 cannot DCE the loop. | ||
| if (result === Symbol.for('benchmark-never')) | ||
| throw new Error('unreachable'); |
There was a problem hiding this comment.
Incomplete benchmark DCE prevention
Medium Severity
The anti-DCE guard only observes result, but construct-*, set, append, and delete never assign it, so those timed loops can be eliminated. Other Node benchmarks keep the last constructed or mutated value alive with an assignment plus assert.ok. As written, those methods may report misleading throughput.
Reviewed by Cursor Bugbot for commit 2edacb0. Configure here.
cursor
Bot
force-pushed
the
cursor/headers-class-performance-859a
branch
from
August 18, 2026 12:49
2edacb0 to
0225f7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Node-side tests and benchmark only. No
deps/undicichanges.