Skip to content

Splat build.ps1 arguments as a hashtable so the CI dispatch inputs work #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rafael-SOWNet wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −5
Open

Splat build.ps1 arguments as a hashtable so the CI dispatch inputs work #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,14 @@ jobs:
PACK_NUGETS: ${{ github.event_name != 'workflow_dispatch' || inputs.pack_nugets || inputs.publish_nuget }}
CREATE_ARCHIVE: ${{ github.event_name != 'workflow_dispatch' || inputs.upload_artifacts }}
run: |
$buildArguments = @()
if ($env:RUN_TESTS -ne 'true') { $buildArguments += '-SkipTests' }
if ($env:COLLECT_COVERAGE -ne 'true') { $buildArguments += '-SkipCoverage' }
if ($env:PACK_NUGETS -ne 'true') { $buildArguments += '-SkipPack' }
if ($env:CREATE_ARCHIVE -ne 'true') { $buildArguments += '-SkipArchive' }
# Splat a hashtable, not an array. Array splatting binds positionally, and
# build.ps1 declares only switches, so any non-empty array fails with
# "A positional parameter cannot be found that accepts argument '-SkipTests'".
$buildArguments = @{}
if ($env:RUN_TESTS -ne 'true') { $buildArguments['SkipTests'] = $true }
if ($env:COLLECT_COVERAGE -ne 'true') { $buildArguments['SkipCoverage'] = $true }
if ($env:PACK_NUGETS -ne 'true') { $buildArguments['SkipPack'] = $true }
if ($env:CREATE_ARCHIVE -ne 'true') { $buildArguments['SkipArchive'] = $true }
./Build/build.ps1 @buildArguments

# Codecov intermittently fails while importing its verification key from Keybase.
Expand Down