docs(auth): log the token value in the idToken example - #3728
Open
armando-navarro wants to merge 1 commit into
Open
docs(auth): log the token value in the idToken example#3728armando-navarro wants to merge 1 commit into
armando-navarro wants to merge 1 commit into
Conversation
The idToken example's subscription logged `string`, a type name rather than a value in that scope, so the snippet would not compile if copied. Log the `token` parameter the callback receives, matching the neighboring authState example. Also correct the comment on the line above, copied from the authState example, which referred to a user rather than the token this example streams. Reland of angular#3652 by saadlalam, whose fix was correct but could not be merged because the CLA check never cleared on that branch.
armando-navarro
added
comp: docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
idTokenexample's subscription logsstring, which is a type name rather than a value in that scope, so the snippet would not compile if copied. This logs thetokenparameter the callback actually receives, matching the neighboringauthStateexample.This is a reland of #3652 by @saadlalam, whose original fix was correct but could not be merged because the CLA check never cleared on that branch. The fix is theirs; relanding it here so it isn't lost. While here, it also corrects the comment on the line above, which was copied from the
authStateexample and referred to a user rather than the token this example streams.