Skip to content

Amuse Tsunami Interface - #1281

Open
elkogerville wants to merge 133 commits into
amusecode:mainfrom
elkogerville:amuse_tsunami
Open

Amuse Tsunami Interface#1281
elkogerville wants to merge 133 commits into
amusecode:mainfrom
elkogerville:amuse_tsunami

Conversation

@elkogerville

@elkogerville elkogerville commented Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This PR adds Tsunami (https://gitlab.com/aatrani/tsunami) as a community code along with tests.

Tsunami is a tidal evolution N-body code similar to Tidymess.

Notes:

  • particles are added to temporary buffers before committing them to Tsunami in commit_particles
  • Tsunami is a private code, and therefore a copy is needed from Dr. Alessandro Alberto Trani before the interface can be compiled.

This PR closes #1274

Note:
The test test_tides in this PR depends on equilibrium_tides_averaged.py, which was written by the Tsunami author Dr. Alessandro Alberto Trani and is currently private. I've reached out to request permission to include it in the AMUSE repository. Until permission is granted, this test will fail.

@elkogerville
creating tsunami directory with amusifier
293b9a0
@elkogerville
defined Tsunami new_particle in interface.py
3000cae
@elkogerville
defining new_particle in Tsunami interface.cc
3f326ec
@elkogerville
tsunami interface.cc cleanup
9f36e14
@elkogerville
rm unused params in Tsunami interface.py
30fa3b2
@elkogerville
defined a tsunami.new_particle and .commit_particles in interface.cc …
0ca63f1 
…using a buffer
@elkogerville
cleaned up Tsunami new_particle in interface.cc
c0786fd
@elkogerville
def commit_particles Tsunami interface.cc, which copies particles fro…
68383e2 
…m new_particle buffer into Tsunami, while taking into account previously commited particles
@elkogerville
defined new_particle in Tsunami interface.py
44a43e8
@elkogerville
Tsunami interface.cc get/set_state
8ef1287
@elkogerville
Tsunami interface.cc def index_within_bounds to check that an index_o…
7f652e7 
…f_the_particle exists inside Tsunami
@elkogerville
refactored Tsunami interface.cc fns to use index_in_bounds
ae8694f
@elkogerville
def get/set_mass and get/set_radius Tsunami interface.cc
71a3697
@elkogerville
Tsunami interface.cc def get/set_position
ed7495b
@elkogerville
Tsunami interface.cc def get/set_velocity and def evolve_model
30ecf29
@elkogerville
added try catch to Tsunami evolve_system interface.cc
77e56a8
@elkogerville
def get/set_state, mass, and radius Tsunami interface.py
5df8831
@elkogerville
rm get/set mass, radius Tsunami interface.py since they are inherited…
d546309 
… with GravitationalDynamicsInterface
@elkogerville
Tsunami interface.cc def get_total_mass, get_center_of_mass_position,…
a9e132d 
… get_center_of_mass_velocity, get_total_radius, get_number_of_particles
@elkogerville
def get_index_of_particle and _of_next_particle tsunami interface.cc
5f19a00
@elkogerville
fixed tsunami interface.cc bug where Npart was icorrectly labeled as …
7f9b956 
…Nparts, and def get_time
@elkogerville
def get_acceleration, def Tsunami configuration params, Tsunami inter…
38bc819 
…face.cc
@elkogerville
Tsunami setters and getters for Tsunami.Conf
b4cd297
@elkogerville
Tsunami config.mk.in
5a258ec
@elkogerville
Tsunami configure.ac
7b48003
@elkogerville
Tsunami amuse_deps file
87aa0d6
@elkogerville
cleanup amuse tsunami packages folder
1c0f08d
@elkogerville
cleaned up tsunami interface.py
8b82ca4
@elkogerville
def __init__.py and interface.py for tsunami in amuse/community
5e1ca02
@elkogerville
fixed makefile and interface.py typo amuse_tsunami
e281a81
elkogerville added 18 commits July 9, 2026 18:05
@elkogerville
def initialize_tidal_parameters tsunami interface.py
ff52d80
@elkogerville
rm whitespace
0abf956
@elkogerville
add spin as a global vector Particles attribute
c8a37e2
@elkogerville
tighten swig version dependency for tsunami
1775faf
@elkogerville
rm tsunami.commit_parameters call from commit_parameters since it was…
df4c2ab 
… causing bugs. this method should be for recommit_parameters only
@elkogerville
fix issue where dynamical tides were activating equilibrium tides ins…
f92c28d 
…tead
@elkogerville
cleanup interface tsunami
e6697c7
@elkogerville
add spin in particle set
f9e0dbc
@elkogerville
tsunami docs
7e8a627
@elkogerville
cleanup tsunami tests
38768b0
@elkogerville
create test_tides
2d126ff
@elkogerville
clean up Tsunami interface of typos, homogenize docstrings
e062d6a
@elkogerville
refactor tsunami.commit_particles to use more robust set logic for ch…
af163a5 
…ecking input particle data shapes
@elkogerville
add omitted logic for deleting stypes in delete_particle
13f1cb1
@elkogerville
docstring for initialize_tidal_parameters
0e86aa6
@elkogerville
cleanup tsunami interfaces
2cb4ab0
@elkogerville
clean up tsunami tests
fdee37f
@elkogerville
add tsunami README detailing installation notes
37fb024
@elkogerville
elkogerville requested a review from a team as a code owner September 11, 2026 14:29
@elkogerville elkogerville added area: community_code Issue concerns a community code and/or its AMUSE bindings area: interfaces Issues related to the standardised interfaces in amuse.community.interface and swappability of codes labels Sep 11, 2026
@elkogerville elkogerville added the kind: feature request The issue requests a feature that AMUSE does not currently have label Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area: community_code Issue concerns a community code and/or its AMUSE bindings area: interfaces Issues related to the standardised interfaces in amuse.community.interface and swappability of codes kind: feature request The issue requests a feature that AMUSE does not currently have

Projects

Development Board
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Tsunami interface to AMUSE

1 participant

@elkogerville