Repository navigation
fix(ci): restore CDN deployment on Python 3.12 (SDK-725) - #637
Merged
Merged
Conversation
Mercy811
marked this pull request as ready for review
November 12, 2026 22:38
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
daniel-graham-amplitude
approved these changes
Nov 12, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 12, 2026
## [8.21.12](v8.21.11...v8.21.12) (2026-11-12) ### Bug Fixes * **ci:** restore CDN deployment on Python 3.12 ([#637](#637)) ([98b1b11](98b1b11))
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restore CDN release preparation on Python 3.12. The 8.21.11 release retry successfully published to npm, then crashed while importing boto3 before uploading any CDN assets. The old boto3 1.14.63 pin resolves botocore 1.17.63 and urllib3 1.25.11, whose vendored six import fails on Python 3.12.
Use boto3 1.44.2 and run the deployment script's
--helpstartup check immediately after installation, before npm publishing. This catches dependency import failures early without making AWS requests.Fixes SDK-725
Validation
ModuleNotFoundError: No module named 'urllib3.packages.six.moves'.python scripts/deploy_s3.py --helppasses; resolves botocore 1.44.2 and urllib3 2.8.0.uv pip checkandgit diff --checkpass.Scope and risk
The AWS Python SDK update affects release tooling. Live S3 uploads, IAM permissions, and CDN delivery have not been verified by these local checks. The startup check verifies imports and CLI initialization only. The existing SDK bundles and deployment script are unchanged.
This PR does not recover the already published 8.21.11 CDN artifacts. That remains an operational follow-up; rerunning semantic-release after its release commit/tag already exists should not be assumed to retry the missed upload.
Checklist