Skip to content

fix: support register measurement and loop-scoped registers - #401

Open
rmshaffer wants to merge 3 commits into
output-simulatorfrom
rmshaffer/measure-register
Open

rmshaffer wants to merge 3 commits into
output-simulatorfrom
rmshaffer/measure-register

Conversation

@rmshaffer

@rmshaffer rmshaffer commented Aug 19, 2026 •

Copy link
Copy Markdown
Member

Issue #, if available:

Description of changes:
Sits on top of #399. Additional changes necessary to support register measurement and loop-scoped registers which allows all tests & notebooks in amazon-braket/autoqasm#119 to pass successfully.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmshaffer
rmshaffer changed the base branch from main to output-simulator August 19, 2026 16:54
@rmshaffer rmshaffer changed the title fix: support register measurement fix: support register measurement and loop-scoped registers Aug 19, 2026
@codecov

codecov Bot commented Aug 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0972751) to head (f9e8723).

Additional details and impacted files
@@                Coverage Diff                 @@
##           output-simulator      #401   +/-   ##
==================================================
  Coverage            100.00%   100.00%           
==================================================
  Files                    50        50           
  Lines                  5164      5186   +22     
  Branches                625       631    +6     
==================================================
+ Hits                   5164      5186   +22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rmshaffer
rmshaffer changed the base branch from output-simulator to main August 19, 2026 19:33
@rmshaffer
rmshaffer changed the base branch from main to output-simulator August 19, 2026 19:35
@rmshaffer
rmshaffer marked this pull request as ready for review August 20, 2026 15:37
@rmshaffer
rmshaffer requested a review from a team as a code owner August 20, 2026 15:37
Comment thread src/braket/default_simulator/openqasm/interpreter.py Outdated
Comment thread src/braket/default_simulator/openqasm/program_context.py Outdated
Comment thread test/unit_tests/braket/default_simulator/openqasm/test_output_helpers.py Outdated
Comment thread test/unit_tests/braket/default_simulator/openqasm/test_output_helpers.py Outdated
@speller26
speller26 force-pushed the rmshaffer/measure-register branch from 58c5483 to 6b7f902 Compare August 21, 2026 00:12
@rmshaffer
rmshaffer force-pushed the rmshaffer/measure-register branch from 5dbf141 to 8acfc39 Compare September 1, 2026 21:08
@rmshaffer
rmshaffer force-pushed the rmshaffer/measure-register branch from 959c0cc to e1b4b66 Compare September 3, 2026 15:36
@speller26
speller26 force-pushed the rmshaffer/measure-register branch from e1b4b66 to f9e8723 Compare September 16, 2026 18:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants