Repository navigation
fix(ci): set PGDATABASE=te_mgmt_dev, add Tier E/X evals, fix step order - #62
Closed
amar-python wants to merge 1 commit into
Closed
amar-python wants to merge 1 commit into
amar-python wants to merge 1 commit into
Conversation
Root cause: PGDATABASE was set to 'postgres' instead of 'te_mgmt_dev'. deploy_all.sh runs psql without -d, so it falls back to PGDATABASE. The \c in te_core_schema.sql then switches to the target database, so tables deploy correctly — but the API and Tier E evals connect to PGDATABASE (postgres), where the te_dev schema does not exist. Fixes: - PGDATABASE: te_mgmt_dev (was: postgres) - API_ALLOW_DESTRUCTIVE: "true" (DeleteEndpoint tests need it) - Deploy step now runs before evals (was: after) - Added Tier X (CSV round-trip) and Tier E (cross-env parity) evals - Added Tier E negative control (02_empty_schema_is_detected) that verifies the fingerprint query returns 0 tables for an empty schema, so the parity eval cannot false-positive on a silent deploy failure Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBrxqChRJtxdvSpFhiUWUy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PGDATABASEwas set topostgresinstead ofte_mgmt_devin the CI workflow. The\cmetacommand inte_core_schema.sqlswitches psql to the correct target database during deploy, so tables land in the right place — but the API, pytest, and Tier E evals connect viaPGDATABASE, which pointed atpostgreswherete_dev.*tables don't exist.API_ALLOW_DESTRUCTIVE: "true"so DELETE-endpoint tests pass.02_empty_schema_is_detected) that verifies the fingerprint query returns 0 tables for an empty schema — so the parity eval cannot false-positive on a silent deploy failure.Changes
.github/workflows/quality-gate.ymlPGDATABASE: te_mgmt_dev,API_ALLOW_DESTRUCTIVE, deploy-before-evals, Tier X/E stepevals/runner.pyevals/expected/tier_e/*.jsonevals/expected/tier_x/*.jsonevals/datasets/tier_e/*/NOTES.txtevals/datasets/tier_x/*/NOTES.txtTest plan
integration (postgres service)CI job passes — all 19 previously-failing API tests should now resolvete_dev.organisations01_all_envs_same_tablesreports 12+ tables across 4 envs (was reporting 0)02_empty_schema_is_detectednegative control passes (0 tables in empty schema)free-tierjob unaffectedGenerated by Claude Code