Repository navigation
docs: audit Terraform storage accounts (closes #151) - #163
Merged
Merged
Conversation
Adds purpose comments to the three storage resources in infra/terraform/main.tf and a new docs/infra/README.md inventorying every account. Captures the D4 review triggers that would re-wire csv-input and run-reports to the code: pg_dump pain or run reports growing large. Nothing removed; csv-input and run-reports kept as provisioned-but-unused per the owner's choice (option c on the audit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #151.
What this does
infra/terraform/main.tf:pg_storageaccount: note that it must stay (pgdata depends on it)pg_datafile share: the Postgres data volumecsv_input+run_reportscontainers: provisioned but currently unused per D4, with explicit review triggersdocs/infra/README.mdwith a full storage account inventory and the folder-structure pattern (sharedinfra/terraform/, per-environment overrides interraform-{env}/)Why
#151 asked: are these storage accounts in use, or vestigial? The audit found:
pg_storagein the shared config) — active for pgdata; its two blob containers are provisioned but unusedOwner decisions captured in the comments
Verification
infra/terraform/main.tfstill parses:terraform fmt -checkrun before commit (or skipped quietly if Terraform isn't on PATH)