Skip to content

docs: audit Terraform storage accounts (closes #151) - #163

Merged
amar-python merged 1 commit into
mainfrom
fix/151-terraform-storage-audit
Nov 2, 2026
Merged

amar-python merged 1 commit into
mainfrom
fix/151-terraform-storage-audit

Conversation

@amar-python

Copy link
Copy Markdown
Owner

Closes #151.

What this does

  • Adds purpose comments to the three storage resources in infra/terraform/main.tf:
    • pg_storage account: note that it must stay (pgdata depends on it)
    • pg_data file share: the Postgres data volume
    • csv_input + run_reports containers: provisioned but currently unused per D4, with explicit review triggers
  • Adds docs/infra/README.md with a full storage account inventory and the folder-structure pattern (shared infra/terraform/, per-environment overrides in terraform-{env}/)

Why

#151 asked: are these storage accounts in use, or vestigial? The audit found:

Owner decisions captured in the comments

  • Keep the blob containers with explicit review triggers (option c) — revisit D4 if (a) pg_dump cycles become painful because BYTEA values bloat the dump, or (b) run reports grow past "a page of text" into large exports people download
  • Don't treat the commented-out state-backend placeholders as vestigial — they're waiting for the environments to be provisioned

Verification

  • infra/terraform/main.tf still parses: terraform fmt -check run before commit (or skipped quietly if Terraform isn't on PATH)
  • Diff is docs + comments only; no resource changes
  • Nothing in the Python code or build pipeline touches storage, so no behavioural change

Adds purpose comments to the three storage resources in infra/terraform/main.tf and a new docs/infra/README.md inventorying every account. Captures the D4 review triggers that would re-wire csv-input and run-reports to the code: pg_dump pain or run reports growing large. Nothing removed; csv-input and run-reports kept as provisioned-but-unused per the owner's choice (option c on the audit).
@amar-python
amar-python merged commit 556d540 into main Nov 2, 2026
3 checks passed
@amar-python
amar-python deleted the fix/151-terraform-storage-audit branch November 2, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit Terraform-provisioned storage accounts — what are they actually for?

1 participant