Skip to content

fix(frontend): full page load for the sign-in redirect, ending hydration errors (#133) #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amar-python merged 1 commit into from
Oct 28, 2026
Merged

fix(frontend): full page load for the sign-in redirect, ending hydration errors (#133) #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion csv-table-hub-main/src/__tests__/session.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,10 @@ describe("requireSession (route guard)", () => {
thrown = e;
}
expect(isRedirect(thrown)).toBe(true);
expect((thrown as { options: { to: string } }).options.to).toBe("/auth");
const { options } = thrown as { options: { to: string; reloadDocument?: boolean } };
expect(options.to).toBe("/auth");
// #133: a client-side redirect during hydration crashed the router (React #520/#422).
expect(options.reloadDocument).toBe(true);
});

it("lets a signed-in user through", () => {
Expand Down
6 changes: 4 additions & 2 deletions csv-table-hub-main/src/lib/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,11 @@ export function authHeaders(): Record<string, string> {
return s ? { Authorization: `Bearer ${s.token}` } : {};
}

/** Route guard (#96): send anyone without a live session to the sign-in page. */
/** Route guard (#96): send anyone without a live session to the sign-in page.
* A full page load, not a client-side redirect: redirecting while the first
* page hydrates broke the router's match tree (React #520/#422, #133). */
export function requireSession(): void {
if (!getSession()) throw redirect({ to: "/auth" });
if (!getSession()) throw redirect({ to: "/auth", reloadDocument: true });
}

/** Change your own password (#117). This session stays; the server ends all others. */
Expand Down
Loading