Skip to content

fix(frontend): patch npm audit findings, 17 to 1 (#132) - #134

Merged
amar-python merged 1 commit into
mainfrom
fix/132-npm-audit
Oct 27, 2026
Merged

amar-python merged 1 commit into
mainfrom
fix/132-npm-audit

Conversation

@amar-python

Copy link
Copy Markdown
Owner

Part of #132: everything except the zod major upgrade. Built on the product owner's decision of 28 Oct to fix #132 before the #60 dry run, so that the clean-VM evidence covers patched code.

Result

npm audit: 17 → 1.

What changes

  • package-lock.json: non-breaking updates within the existing package.json ranges. 66 package versions change.
    • @tanstack/react-start 1.168.42 → 1.169.4, plus the start-* packages. This fixes the critical unauthenticated reflected XSS.
    • shell-quote 1.10.0 → 1.12.0 (critical).
    • vite 8.2.1 → 8.3.5, launch-editor, undici 8.10.0 → 8.12.3, seroval 1.6.2 → 1.7.2, brace-expansion, js-yaml, source-map-js (all high).
    • Others carried along: @tanstack/react-router 1.170.25 → 1.170.46, rolldown 1.2.3 → 1.2.15, postcss, and diff 8 → 9 (a sub-dependency its parent allows).
  • package.json: vitest and @vitest/ui move from ^4.1.10 to ^4.1.12, which fixes the moderate path traversal in @vitest/mocker. npm also added the missing newline at the end of the file.
  • src/routes/__root.tsx: the newer router types errorComponent's error as unknown, so the root error component now accepts unknown. reportLovableError already takes unknown.

How the lock was produced

Checks

Run on a clean install with npm 10.9.9 / Node 22.23.4, the same toolchain as the dev machine's WSL:

  • npm ci: 506 packages, exit 0.
  • npm audit: 1 high (zod).
  • vitest: 12 files, 139 passed.
  • tsc --noEmit: exit 0.
  • NITRO_PRESET=node-server build: OK.
  • Browser check (Playwright, production build):

After merging

Rebuild the #60 bundle (runbook A4), so the dry run uses this code.

Still open on #132

The zod 3 → 4 upgrade.


Generated by Claude Code

All non-breaking updates within the existing ranges, including
@tanstack/react-start 1.168.42 -> 1.169.4 (critical unauthenticated
reflected XSS), shell-quote, vite, undici, seroval; vitest and
@vitest/ui 4.1.10 -> 4.1.12. Lock normalised with npm 10 so a clean
npm ci works on the build machine (#130). __root.tsx: the router now
types errorComponent's error as unknown.

Remaining: zod <4.6.6 (high), needs the zod 4 major upgrade.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontend dependencies: npm audit reports 6 critical (TanStack Start XSS) and 8 high

2 participants