Repository navigation
fix(frontend): patch npm audit findings, 17 to 1 (#132) - #134
Merged
Merged
Conversation
All non-breaking updates within the existing ranges, including @tanstack/react-start 1.168.42 -> 1.169.4 (critical unauthenticated reflected XSS), shell-quote, vite, undici, seroval; vitest and @vitest/ui 4.1.10 -> 4.1.12. Lock normalised with npm 10 so a clean npm ci works on the build machine (#130). __root.tsx: the router now types errorComponent's error as unknown. Remaining: zod <4.6.6 (high), needs the zod 4 major upgrade. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #132: everything except the
zodmajor upgrade. Built on the product owner's decision of 28 Oct to fix #132 before the #60 dry run, so that the clean-VM evidence covers patched code.Result
npm audit: 17 → 1.zod <4.6.6, which needs zod 4 (a major version). That's left for a follow-up, as Frontend dependencies: npm audit reports 6 critical (TanStack Start XSS) and 8 high #132 proposes.What changes
package-lock.json: non-breaking updates within the existingpackage.jsonranges. 66 package versions change.@tanstack/react-start1.168.42 → 1.169.4, plus thestart-*packages. This fixes the critical unauthenticated reflected XSS.shell-quote1.10.0 → 1.12.0 (critical).vite8.2.1 → 8.3.5,launch-editor,undici8.10.0 → 8.12.3,seroval1.6.2 → 1.7.2,brace-expansion,js-yaml,source-map-js(all high).@tanstack/react-router1.170.25 → 1.170.46,rolldown1.2.3 → 1.2.15,postcss, anddiff8 → 9 (a sub-dependency its parent allows).package.json:vitestand@vitest/uimove from^4.1.10to^4.1.12, which fixes the moderate path traversal in@vitest/mocker. npm also added the missing newline at the end of the file.src/routes/__root.tsx: the newer router typeserrorComponent'serrorasunknown, so the root error component now acceptsunknown.reportLovableErroralready takesunknown.How the lock was produced
npm audit fixcrashes with an internal error:Cannot read properties of null (reading 'edgesOut').npm install --package-lock-only).npm cifails again with the Frontend package-lock.json out of sync: clean npm ci fails, blocking the #60 bundle build #130 error (Missing: lru-cache@11.5.3), because npm 11 lays out that nested package differently.Checks
Run on a clean install with npm 10.9.9 / Node 22.23.4, the same toolchain as the dev machine's WSL:
npm ci: 506 packages, exit 0.npm audit: 1 high (zod).tsc --noEmit: exit 0.NITRO_PRESET=node-serverbuild: OK./authshows "Sign in to CSV Migrator" with the 3 fields;/redirects to/authwhen signed out;/auth,/and/auditall return 200.main's dependencies, so they're pre-existing and not from this update. They're logged as Frontend logs React hydration errors #520/#422 on /auth in production builds (pre-existing) #133.After merging
Rebuild the #60 bundle (runbook A4), so the dry run uses this code.
Still open on #132
The
zod3 → 4 upgrade.Generated by Claude Code