Repository navigation
fix(dev): reload the API only for changes under api/ (#118) - #127
Merged
Merged
Conversation
uvicorn --reload watched the whole repo, which sits in a OneDrive folder, so a sync anywhere could restart or stop the API. Watch api/ only, in start-api.ps1 and the QUICKSTART command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118, using option B as decided by the product owner on 27 Oct 2026: remove the likely cause of the silent stop rather than reproduce it.
What changes
scripts/start-api.ps1and the QUICKSTART command now runuvicorn … --reload --reload-dir api.dist/) could trigger a restart. That restart is the likely cause of the 27 Oct stop.api/still reload as before.Checks
I ran uvicorn here with the new flags (port 8011):
Will watch for changes in these directories: ['…/api'].docs/QUICKSTART.md: 0 reloads.api/__init__.py: 1 reload. Both files were then restored.start-api.ps1parses with 0 errors (pwsh) and stays ASCII-only.Not proven
The 27 Oct stop wasn't reproduced. This removes its most likely cause but doesn't prove it was the cause. #118 is closed on that basis, by the product owner's decision. If the API stops by itself again, reopen #118.
Done when
Will watch for changes in these directories: [...\api].Generated by Claude Code