Repository navigation
feat(auth): lock accounts after repeated failed sign-ins (#102) - #103
Merged
Merged
Conversation
After LOGIN_MAX_FAILURES (10) wrong passwords within LOGIN_LOCKOUT_MINUTES (15), the account is locked for 15 minutes. A locked account gets the same 401 as any other failure; a success clears the count. Migration 0005 adds the counters to control.users and, like 0004, skips tenant schemas. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102 (approved by you on 26 Oct). Part of ART Milestone 2 (BR-36).
Behaviour
LOGIN_MAX_FAILURESandLOGIN_LOCKOUT_MINUTES.0005. Adds the counters tocontrol.users. Like0004, it only touches the shared control schema, not tenant schemas.Evidence
All runs are against local PostgreSQL 16.
scripts/test_report.py --strict)tests/test_accounts.py• the 11th attempt is refused even with the right password
• 9 failures and then a success resets the count
• the lock expires
• old failures fall out of the window
scripts/lint.shGenerated by Claude Code