Skip to content

Ragged rows: confirm rejection and counts with a regression test (F2) #192

Closed

Description

@amar-python

Raised by the product owner on 4 Nov 2026 as "F2: ragged row dropping" in the code review feedback. Not reproduced in this session.

What the code shows (verified at c7bebd1)

  • api/services/csv_parse.py defines ragged_row_reason(raw, width), which gives a reason for rows whose width differs from the header.
  • tests/test_ragged_rows.py exists. I have not confirmed whether it asserts that each ragged row is rejected with a reason and counted, or only that the import succeeds.

Proposed

  • Confirm what the existing test asserts. Extend it if it doesn't check the reject and count behaviour.
  • Assert the accounting identity: total rows = inserted + duplicates + failures, and each ragged row has a stored reason.

Done when

  • A run of tests/test_ragged_rows.py shows the counts, with the accounting identity checked.
  • The test fails when the ragged-row check is removed (mutation check).

Generated by Claude Code

Activity

  1. amar-python commented on Nov 9, 2026

    @amar-python
    OwnerAuthor

    Fixed in #202 (merged as 203c8ae).


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions