Change x-for to allow loops like (foo)in(bar) - #4897
Merged
Conversation
Currently, the loop in x-for must have a space between the in/of and both the bindings and the source expression. However, JS doesn't require the space - only that they are separate tokens - so `(item, index) in list` may be minified to `(item,index)in list` which `x-for` no longer parses. This patch alters the regular expression in `parseForExpression` to split the bindings and expression on word boundries (`\b`) rather than spaces, to support this syntax.
Contributor
|
I get it...but like why? |
Contributor
Author
|
In my app, I have a Rust macro that runs some basic minification over passed-in javascript, and it minifies |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the loop in x-for must have a space between the in/of and both the bindings and the source expression. However, JS doesn't require the space - only that they are separate tokens - so
(item, index) in listmay be minified to(item,index)in listwhichx-forno longer parses.This patch alters the regular expression in
parseForExpressionto split the bindings and expression on word boundries (\b) rather than spaces, to support this syntax.