Repository navigation
feat(context): simplify service setup and connection checks #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Changes from all commits
0b88d5c
5db62f8
4e22b0c
8b1b967
fdcd977
38bbd35
0796d42
e6ee8a8
e488667
300ee4f
8419382
4997b66
e1b2593
6c4fa30
13ccbef
ad4b832
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| **Verdict:** READY | ||
| **Scope:** Final connect-services recipe against the agreed concise service-setup guide. | ||
| **Evidence limits:** Static documentation review; provider authentication and reads were not exercised. Sources checked 2026-10-14. | ||
|
|
||
| ## Verified | ||
|
|
||
| - **Choice:** Four options compare use cases, advantages and limits; category tables retain CLI and MCP/native alternatives. | ||
| - **Accuracy:** Context savings are conditional, matching [Playwright](https://playwright.dev/agent-cli/introduction#playwright-cli-vs-mcp) and [Claude Code's deferred tools](https://code.claude.com/docs/en/mcp#scale-with-mcp-tool-search). No universal speed or freshness claim remains. | ||
| - **Setup:** Commands are labeled examples. The Figma command matches its [official setup guide](https://developers.figma.com/docs/figma-mcp-server/remote-server-installation/). Reusable API access points to Generate Skill. Its cross-skill link uses the source URL so installation does not break it. | ||
| - **Verification:** Existing action maps relevant memory, performs target-specific reads and fills the category report without changing services. | ||
| - **Checks:** Architecture rules pass; local Markdown links have no broken target; all three bundled recipes validate; diff whitespace check passes. | ||
|
|
||
| ## Blockers | ||
|
|
||
| None. | ||
|
|
||
| ## Suggestions | ||
|
|
||
| | Finding | Evidence | Minimal improvement | | ||
| | --- | --- | --- | | ||
| | API and SDK are different layers, though both are useful choices for this guide | [Octokit wraps GitHub APIs](https://github.com/octokit/octokit.js), checked 2026-10-14 | Optionally say “An SDK can wrap an API”; current use-case distinction is sufficient | |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Review: Connect services | ||
|
|
||
| - **Verdict**: approve | ||
| - **Diff**: `origin/next...HEAD` plus tracked working edits to the recipe, verification action and report | ||
| - **Axes run**: code, functional, relevancy | ||
| - **Date**: 2026-10-14 | ||
| - **Findings**: 0 critical, 0 warning, 0 minor; formal findings limited to concrete P0/P1 risks | ||
|
|
||
| ## Phases | ||
|
|
||
| ### Phase 1: Recipe and setup | ||
|
|
||
| - [x] Rename recipe and update its references: `README.md:239`, `token-optimization.md:452`, new `connect-services.md` replaces `mcp-installation.md`. | ||
| - [x] Eight actual H4 category headings with emojis: `connect-services.md:49–113`. | ||
| - [x] Service tables expose linked CLI, MCP/native and API/SDK alternatives; unsupported Google CLI labeled: `connect-services.md:53–122`. | ||
| - [x] Explain memory mapping and link category memory templates: `connect-services.md:5`, `connect-services.md:47–115`. | ||
| - [x] Three actionable steps; installation checks existing access, follows documentation, then authenticates; code examples belong to bullets: `connect-services.md:43`, `connect-services.md:125–165`. | ||
| - [x] Bold introductory labels use a colon; ordinary bullets avoid unnecessary labels: `connect-services.md:131`, `connect-services.md:138`, `connect-services.md:147`. | ||
|
|
||
| ### Phase 2: Verification | ||
|
|
||
| - [x] Public `verify` entry routes to `verify-connection`: `02-project-memory/SKILL.md:4`, `02-project-memory/SKILL.md:14–15`, `02-project-memory/SKILL.md:29`. | ||
| - [x] Resolve the local recipe and read it by relative path; relevant memory is not a fixed filename list: `05-verify-connection.md:7`, `05-verify-connection.md:15–17`. | ||
| - [x] Simple map, read and report process; rules replace a terminal Test section; unavailable context never means not needed: `05-verify-connection.md:15–26`. | ||
| - [x] Read-only operation excludes writes, installs, login, memory changes and secret output; successful reads must match account and target: `05-verify-connection.md:25–26`. | ||
| - [x] One category per four-column report; aggregate status preserves failed or unverified required access: `connection-report.md:4–24`. | ||
|
|
||
| ### Phase 3: Validator support | ||
|
|
||
| - [x] CLI validation permits H4 subsections only below a direct numbered H3 step; malformed numbered headings still fail; unit cases cover valid subsections, orphans, changed parents and malformed headings: `recipe-validation.ts:397–439`, `recipe-validation.unit.test.ts:120–155`. | ||
|
|
||
| ## Findings | ||
|
|
||
| None. | ||
|
|
||
| ## Verification | ||
|
|
||
| | Metric | Value | | ||
| | --- | --- | | ||
| | Verified | 100% (12/12) static acceptance criteria reviewed | | ||
| | Files checked | All 10 changed PR files: README, recipe validator, validator unit tests, context CATALOG, project-memory router, verification action, connection report, new connect-services recipe, deleted mcp-installation recipe, token-optimization recipe; three current tracked doc edits included | | ||
| | Static check | `git diff --check origin/next` exited 0; scoped README/plugins/CLI search found no old `mcp-installation` reference | | ||
| | Unchecked | Provider execution and runtime test results: not-applicable to this read-only static review; provider documentation contents and link availability not independently rechecked | | ||
| | Unplanned | None; validator relaxation directly supports requested H4 category structure | | ||
| | Completion score | 100: every supplied criterion examined | | ||
| | Quality score | 92: criteria statically fulfilled; small duplication and local catalogue resolution indirection remain; runtime/provider behavior is not established by this review | | ||
| | Non-blocking simplification | `connect-services.md:9–39`: graph shows a decision sequence, table shows tradeoffs; their functions differ, but graph repeats CLI preference and API fallback. Retaining just the comparison table and a short selection sentence would reduce page length without losing useful choice information | | ||
| | Non-blocking clarity | `05-verify-connection.md:15`: local recipe resolution has an existing authoritative location policy at `../../12-cook/references/recipe-locations.md`; linking that policy would remove ambiguity without duplicating it | | ||
| | Non-blocking router consistency | `02-project-memory/SKILL.md:36`: “report of what changed” predates the read-only verify entry; scoping it to setup/refresh/rewire would align it with verify's observed-results report | |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| --- | ||
| name: 02-project-memory | ||
| description: Build the project's memory of its architecture, conventions, and decisions, and wire it into your AI tools. Use when the user wants to set up or refresh project memory, or rewire it into a tool. Not for editing one existing memory file. | ||
| argument-hint: setup | refresh | rewire | ||
| description: Build project memory and wire it into AI tools. Use when the user wants to set up or refresh memory, rewire it, or verify the assistant's service connections. Not for editing one existing memory file. | ||
| argument-hint: setup | refresh | rewire | verify | ||
| --- | ||
|
|
||
| # Project Memory | ||
|
|
@@ -11,6 +11,8 @@ flowchart LR | |
| new([no argument, or setup]) --> scan --> write --> sync --> wired([memory wired]) | ||
| update([refresh]) --> scan --> check --> write | ||
| rewire([rewire]) --> sync | ||
| verify([verify]) --> verify-connection | ||
| verify-connection --> reported([connection report]) | ||
| scan -.-> empty([nothing to remember]) | ||
| ``` | ||
|
|
||
|
|
@@ -24,10 +26,11 @@ Run the flow above, reading only the next action file. | |
| | write | write the memory | | ||
| | check | show what drifted, change nothing | | ||
| | sync | pick the tools, wire it in | | ||
| | verify-connection | verify the assistant's service access | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check et verify a côté c'est bizarre ça rejoint mon sentiment qu'on fait faire des choses au skill qui n'est peut être pas sa responsabilité |
||
|
|
||
| ## Transversal rules | ||
|
|
||
| - If a referenced file cannot be read, stop and say so. Never invent its content. | ||
| - Never invent unreadable content; setup, refresh and rewire stop when a referenced file cannot be read. | ||
| - Ask before anything ambiguous. Never default silently. | ||
| - A bank that already exists changes only through what the user approved, file by file and line by line. | ||
| - End with a short report of what changed. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ici ça marche plus pour ta nouvelel action y'a pas de changement en soit ? |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # 05 - Verify Connection | ||
|
|
||
| Check project access and fill the report. | ||
|
|
||
| ## Input | ||
|
|
||
| The project's bank in `aidd_docs/memory/` and the local `connect-services.md` recipe. | ||
|
|
||
| ## Output | ||
|
|
||
| A printed report using [connection-report.md](../assets/connection-report.md). | ||
|
|
||
| ## Process | ||
|
|
||
| 1. **Map**: Resolve `connect-services.md` from the local recipe catalogue, then read it by its relative path and read the relevant project memory to identify required services, accounts and targets. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Besoin de la notion de relative path, il sait pas le faire seul ? |
||
| - Include any other relevant memory files or services. | ||
| - Mark missing context as unverified, never as not needed. | ||
| 2. **Check**: Inspect available CLI, MCP, native or API access and perform one read against each required account and target. | ||
| - Continue checking the other services when one fails. | ||
| 3. **Report**: Fill `connection-report.md` from observed results, with one row per category. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. En cas d'erreur ou blocage on fait quoi je ne vois pas ce cas de figure |
||
|
|
||
| ## Rules | ||
|
|
||
| - Check the assistant access the project requires; the catalogue is not an installation checklist. | ||
| - No writes, installs, login flows, configuration or memory changes, or secret output. | ||
| - A configured tool alone never proves access; report success only after a read matches the intended account and target. | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Connection Report | ||
|
|
||
| <!-- | ||
| - Keep every category and group its services. | ||
| - Name each tool, account and target. | ||
| - Keep results short; name one corrective action for each problem. | ||
| - Use the worst required result: failed, not configured, unverified. | ||
| - Pass only when every required read succeeds. | ||
| - Mark not needed only when no access is required. | ||
| - Remove this comment from the report. | ||
| --> | ||
|
|
||
| | Category | Tool / target | Status | Evidence / next step | | ||
| | --- | --- | --- | --- | | ||
| | Version control | | | | | ||
| | Ticketing | | | | | ||
| | Documentation and workspace | | | | | ||
| | Browser | | | | | ||
| | Design | | | | | ||
| | Monitoring | | | | | ||
| | Deployment | | | | | ||
| | Database | | | | | ||
|
|
||
| ✅ All required reads passed · ❌ Read failed · 🔌 Not configured · ⚠️ Unverified · ⏭️ Not needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Est-ce que la description perd un peu son sens avec ça , on veut gérer la memoire AI du projet et on lie avec des vérifications techniques