Repository navigation
test(cli): cover GitHub token verification at the HTTP boundary #467
Description
Context
The July audit grouped global command orchestration, plugin restore and authentication coverage in one issue. PR #795 replaces that command topology and already adds focused coverage for the surviving flows:
statusis retired and update is split by AI/IDE scope.doctor,statusand restore behavior have dedicated tests, including the empty-project health regression.AuthProviderAdaptercovers stored-token and external-provider login/status paths.
The remaining uncovered boundary is GhTokenAdapter.verifyToken: it turns a GitHub HTTP response into an authenticated login or an authentication failure.
Target
Add isolated tests for GhTokenAdapter using its HTTP-client port. Do not call GitHub and do not invoke a host CLI.
Acceptance criteria
- A successful mocked GitHub user response returns the expected login.
- A rejected, malformed, or non-success response becomes the documented authentication error.
- The request carries the supplied token only in the authorization mechanism required by the adapter; neither assertion failures nor errors expose it.
- Tests use the HTTP port fake/mock, never a live GitHub request.
Boundary
Do not duplicate AuthProviderAdapter coverage, restore E2E scenarios, or the retired *AllUseCase topology. This is one HTTP-adapter contract.
Activity
[-]test(cli): the four *AllUseCase orchestrators are the least-tested, most-used code in the project[/-][+]test(cli): cover GitHub token verification at the HTTP boundary[/+]blafourcade commentedon Sep 9, 2026
Backlog refinement: the original omnibus audit is superseded by #795’s command topology and focused tests. #467 now owns only the missing GitHub-token HTTP boundary contract; status remains Todo, without milestone.
fix(cli): validate GitHub token responses without leaking credentials (…