Repository navigation
Fix forwarded client IP handling behind Coolify - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
coolify-proxyfrom inside the Shopware container at bootREMOTE_ADDRshortcutx-forwarded-forin addition to the existing proto/port headersWhy
The firewall uses Shopware/Symfony
Request::getClientIp(). Without trustingX-Forwarded-For, external requests are reported as the Docker-side Traefik IP (for example172.21.0.3), so blocking that address can affect multiple visitors. TrustingREMOTE_ADDRwhile enabling forwarded-for would also allow direct internal callers to spoof the forwarded client IP.