Skip to content

[CLIENT-3434] Fix the wrong client config policy used for client.batch_{operate,apply,remove,write}() when a command-level batch policy is passed as an argument - #766

Draft
juliannguyen4 wants to merge 5 commits into
devfrom
CLIENT-3434-fix-default-policy-values-for-batch-write-commands
Draft

[CLIENT-3434] Fix the wrong client config policy used for client.batch_{operate,apply,remove,write}() when a command-level batch policy is passed as an argument#766
juliannguyen4 wants to merge 5 commits into
devfrom
CLIENT-3434-fix-default-policy-values-for-batch-write-commands

Conversation

@juliannguyen4

@juliannguyen4 juliannguyen4 commented Apr 29, 2025

Copy link
Copy Markdown
Collaborator

Documentation

TODO:
docs, regression test

@codecov-commenter

codecov-commenter commented Apr 29, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (21cfc63) to head (de1a5fc).

Files with missing lines Patch % Lines
src/main/client/batch_operate.c 88.88% 1 Missing ⚠️
src/main/client/batch_write.c 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #766      +/-   ##
==========================================
+ Coverage   85.46%   85.47%   +0.01%     
==========================================
  Files         101      101              
  Lines       14661    14687      +26     
==========================================
+ Hits        12530    12554      +24     
- Misses       2131     2133       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

DomPeliniAerospike and others added 3 commits May 30, 2025 10:13
…rsing policies

Added documenation explaining when each default is used.
Added batch_parent_write as global default of batch_operate function.
…t-policy-values-for-batch-write-commands

# Conflicts:
#	doc/client.rst
#	src/main/client/batch_apply.c
#	src/main/client/batch_operate.c
#	src/main/client/batch_remove.c
#	src/main/client/batch_write.c
…t-policy-values-for-batch-write-commands

# Conflicts:
#	aerospike-client-c
@juliannguyen4 juliannguyen4 changed the title [CLIENT-3434] Fix the wrong client config policy used for client.batch_{operate,apply,remove,write}() when a transaction-level batch policy is passed as an argument [CLIENT-3434] Fix the wrong client config policy used for client.batch_{operate,apply,remove,write}() when a command-level batch policy is passed as an argument Aug 12, 2026
… and batch_operate policies being applied first before command level policies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants