Repository navigation
fix(docker): handle JMX exporter release tag prefixes - #355
Merged
Merged
Conversation
Extract source archives without relying on their root directory name and normalize the Maven artifact version before copying the agent JAR. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the existing digest while making the Alpine release line explicit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix JMX exporter image builds for upstream release tags with an optional
vprefix.The latest JMX publishing run failed because
v1.6.0was used to construct/tmp/jmx_exporter-v1.6.0, but the GitHub source archive extracts intojmx_exporter-1.6.0.Extract the archive directly into
/srcwith--strip-components=1, so the build does not depend on the archive directory name. Strip an optional leadingvwhen locating the Maven artifact, then copy it to a stable filename for the final image. Preserve the operator-facing/jmx_prometheus_javaagent.jarsymlink.This also supports the upstream
1.7.0update in #348. Publishing triggers and the pinned JMX exporter version are unchanged. No test script is included, as requested.Replace the final-stage
alpine:latesttag withalpine:3.24, retaining the existing digest (Alpine 3.24.2). This makes the release line explicit without changing base image contents and keeps Renovate tracking tag and digest updates.Validation
Reproduced the original
mv: cannot stat '/tmp/jmx_exporter-v1.6.0'failure before the fix:Result before the fix: failed with the same error as CI.
After the fix, ran:
Result: passed for all three release tags, including complete image builds and runtime checks for the JAR and symlink.
git diff --cached --check: passed.make test/make lint: not run; this change only affects the JMX image Dockerfile. Local builds used the host architecture; the CI multi-platform publishing job was not rerun.Type of Change
Checklist