Skip to content

FORMS-28648 : added prefill tests cases for all missing core components and fixed a product bug in scribble component - #2012

Open
armaang1729 wants to merge 2 commits into
devfrom
FORMS-28651/prefill-tests
Open

armaang1729 wants to merge 2 commits into
devfrom
FORMS-28651/prefill-tests

Conversation

@armaang1729

Copy link
Copy Markdown
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@armaang1729 armaang1729 changed the title FORMS-28651 : added prefill tests cases for all missing core components and fixed a product bug in scribble component FORMS-28648 : added prefill tests cases for all missing core components and fixed a product bug in scribble component Oct 29, 2026
Armaan Gupta and others added 2 commits November 3, 2026 09:06
A prefilled signature rendered the image but never added the clear
button or set _signSubmitted, so users could not remove it.

Co-Authored-By: Claude <noreply@anthropic.com>
Stub the fd:dataUrl response with cy.intercept and load existing
fixtures with a dataRef param, covering numberinput, checkbox,
checkboxgroup, switch, imagechoice, emailinput, telephoneinput,
datetime, termsandconditions and scribble.

Co-Authored-By: Claude <noreply@anthropic.com>
@armaang1729
armaang1729 force-pushed the FORMS-28651/prefill-tests branch from 5ed5859 to 7eb3b28 Compare November 3, 2026 03:41
@adobe-bot

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

1 similar comment
@adobe-bot

Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@codecov

codecov Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants