Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csv-generatecan drop its configuredeofwhen the final text record crosses a stream read boundary. The same data produces the suffix at a larger read size, so generated files can inconsistently lose their trailing newline or custom terminator. The documentedeofoption promises trailing characters.Reproduces on csv-generate 4.6.2 and the parent revision:
The overflowing record is emitted immediately. On the next read, finalization sees an empty data buffer and closes without emitting EOF. Treat the pending text-mode EOF as output to flush, even when no record text remains. The existing end-state guard prevents duplicate suffixes; empty output and object-mode records retain their current behavior. After an overflow, the suffix can be emitted as a separate final chunk.
Four new regressions fail before the fix and pass afterward, covering callback, sync, async iteration and Web Stream APIs. The tests also cover custom row delimiters, delayed output, fixed-size boundaries, exactly-once emission, empty output and object mode.
Related to #555, which fixes fixed-size remainder consumption. This also reproduces with the default
fixed_size: falseafter that change. Generated distributions were rebuilt and checked, and are left to the release build process.