Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom
cast_datefunction can throw directly fromparser.write()while parsing a complete field. The stream'serrorevent and callback then miss the exception. Ordinary customcastfunctions already use the parser's error return path.Catch
cast_dateexceptions in the same place and return them to the stream adapter. Make the Web Stream adapter throw returned parser errors so the active write rejects with the same error as the readable side. This preserves the existing Web Stream behavior for date callback exceptions and also covers ordinary cast and syntax errors. The synchronous API continues to throw the original error.Validation:
skip_records_with_erroron/off, exact error identity and one error event/callback.git diff --checkpass.AI-assisted implementation and local verification using Codex.