Repository navigation
Conversation
Under WSL 2, apps installed, updated or removed in the distro show up correctly in the Windows Start menu only after WSL restarts. Previously the end-of-run reboot offer only appeared for System Tasks, Docker and Drivers. - Extract reboot decision into _task_wants_reboot(); under WSL 2 any item that changed something now sets needs_reboot (exit code 3 still skips the prompt) - Move _is_wsl2 from the Firecracker installer to _shared.sh so it can be reused, with an optional version-file argument for testing - Use WSL-specific prompt and messages (restart WSL, 'wsl --shutdown') - Add unit tests for _is_wsl2 and _task_wants_reboot (441 total) - Require PRs to target dev: update CONTRIBUTING and PR template - Update CHANGELOG and test count badge
Update unique cloners badge to 85 and unit test count to 443.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 1.11.1: under WSL 2, every run that changed something now offers to restart WSL at the end, so apps installed, updated or removed in the distro show in the Windows Start menu. Also corrects CONTRIBUTING.md, the README and the PR template to say pull requests target dev.
Type of change
Checklist
Testing done
CI on dev: unit tests 443 passed, 0 failed, 2 skipped; ShellCheck -S error clean on the main script, lib/ and lib/installers/. The WSL restart offer was run on a Fedora 44 WSL 2 install (WSLg 1.0.79): a three-item run ending in Flatpak Setup offered the restart, Y restarted WSL, and the apps then showed in the Start menu. Other WSL distros were not run. Outside WSL the end-of-run prompt is unchanged (covered by unit tests).
Safe to merge: yes. Nothing changes outside WSL 2.
Upgrade needs: nothing.
Related issues
Fixes #76
Fixes #77