Repository navigation
Run version validation when promotion labels change - #414
Merged
Merged
Conversation
Run the version gate instead of creating a skipped check that can supersede the passing result required by branch protection. Add regression checks for label triggers and unconditional validation.
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run version validation on label events so branch protection sees a completed check during promotion.
Promotion #413 fails with HTTP 422 because adding
promote-to-maincreates a newer skippedversion-gatecheck. The earlier successful check does not keep the ref update open.How it works
flowchart LR A[Label added or removed] --> B[Run unchanged version validator] B --> C[Promotion waits for checks] C --> D[Branch protection verifies checks before fast-forward]What changed
Blast radius
Test plan
bash tests/test-version-gate.sh: 41 passedbash tests/test-promote.sh: 30 passedPost-merge verification
Rerun #413 checks and guarded promotion after this fix reaches dev, then verify the release tag. This remains unverified until that run succeeds.
No protection bypass or manual ref update is part of this change.