Repository navigation
ATOM-TLI-001: Define tenant-local identity architecture and contracts - #137
arvindh123 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
atom-docs | 66d264b | Commit Preview URL Branch Preview URL |
Oct 12 2026, 07:29 PM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66d264bb80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 2. Ship all namespace-aware readers/writers, guards, tokens, caches and lifecycle | ||
| behavior. Deploy compatible binaries only, then apply activation migration/gate. | ||
| Record a minimum compatible version; startup must reject unsafe downgrades after |
There was a problem hiding this comment.
In a rolling PostgreSQL deployment, the first binary containing the activation migration applies it automatically at startup, while older replicas may still serve requests; those readers can then encounter the duplicate cross-tenant identifiers that lines 122–126 explicitly call ambiguous. A minimum-version check in the new binary cannot stop already-running old replicas, so this needs a separate pre-activation release deployed across the fleet before a later release embeds the index-relaxation migration (or an equivalent database-enforced fence).
AGENTS.md reference: AGENTS.md:L150-L150
Useful? React with 👍 / 👎.
1 participant
Issue #99 requires independent app-user identities, while current signup, email uniqueness and recovery still use the global identity model. This first staged PR proposes the architecture and compatibility contract for implementing that isolation.
Refs #99; ATOM-TLI-001. This PR deliberately leaves the parent issue open. It targets
feature/tenant-local-identities, created frommainat775a326.Changes
Compatibility and migration
No runtime, database, generated API or frozen v1 contract changes. The documents are proposals for architecture review, not claims that tenant-local authentication is available. Implementation and final stabilization remain subsequent PRs. Applied baseline migrations remain untouched.
Validation
Passed locally:
cargo fmt --checkgit diff --cached --checkEnvironment limitations:
cargo clippy --locked -- -D warningswas attempted but could not finish: the Windowsaws-lc-sysbuild requires NASM, which is unavailable (the MSVC feature probe also failed).python scripts/test-v1-contracts.pycould not validate on this Windows checkout: the initial shell was inaccessible; retry with Git Bash reached the existing CRLF shell script and failed atset -euo pipefail.Review focus
Accept or amend the RFC namespace, compatibility, admission and cutover decisions before ATOM-TLI-002. Merging this PR does not enable the feature or close #99.